Re: [Intel-gfx] [PATCH 5/6] drm/i915: Remove inline from sseu helper functions

2019-05-02 Thread Summers, Stuart
On Thu, 2019-05-02 at 17:58 +0300, Jani Nikula wrote: > On Thu, 02 May 2019, "Summers, Stuart" > wrote: > > On Thu, 2019-05-02 at 10:15 +0300, Jani Nikula wrote: > > > Acked-by: Jani Nikula > > > > Jani, based on Daniele's feedback, I'm planning on squashing this > > patch > > with the patch

Re: [Intel-gfx] [PATCH 5/6] drm/i915: Remove inline from sseu helper functions

2019-05-02 Thread Jani Nikula
On Thu, 02 May 2019, "Summers, Stuart" wrote: > On Thu, 2019-05-02 at 10:15 +0300, Jani Nikula wrote: >> Acked-by: Jani Nikula > > Jani, based on Daniele's feedback, I'm planning on squashing this patch > with the patch that moves these helper functions to intel_sseu.h. Any > issue keeping your

Re: [Intel-gfx] [PATCH 5/6] drm/i915: Remove inline from sseu helper functions

2019-05-02 Thread Summers, Stuart
On Thu, 2019-05-02 at 10:15 +0300, Jani Nikula wrote: > On Wed, 01 May 2019, "Summers, Stuart" > wrote: > > On Wed, 2019-05-01 at 14:19 -0700, Daniele Ceraolo Spurio wrote: > > > > > > On 5/1/19 2:04 PM, Summers, Stuart wrote: > > > > On Wed, 2019-05-01 at 13:04 -0700, Daniele Ceraolo Spurio > >

Re: [Intel-gfx] [PATCH 5/6] drm/i915: Remove inline from sseu helper functions

2019-05-02 Thread Jani Nikula
On Wed, 01 May 2019, "Summers, Stuart" wrote: > On Wed, 2019-05-01 at 14:19 -0700, Daniele Ceraolo Spurio wrote: >> >> On 5/1/19 2:04 PM, Summers, Stuart wrote: >> > On Wed, 2019-05-01 at 13:04 -0700, Daniele Ceraolo Spurio wrote: >> > > Can you elaborate a bit more on what's the rationale for

Re: [Intel-gfx] [PATCH 5/6] drm/i915: Remove inline from sseu helper functions

2019-05-01 Thread Summers, Stuart
On Wed, 2019-05-01 at 14:19 -0700, Daniele Ceraolo Spurio wrote: > > On 5/1/19 2:04 PM, Summers, Stuart wrote: > > On Wed, 2019-05-01 at 13:04 -0700, Daniele Ceraolo Spurio wrote: > > > Can you elaborate a bit more on what's the rationale for this? do > > > you > > > just want to avoid having too

Re: [Intel-gfx] [PATCH 5/6] drm/i915: Remove inline from sseu helper functions

2019-05-01 Thread Daniele Ceraolo Spurio
On 5/1/19 2:04 PM, Summers, Stuart wrote: On Wed, 2019-05-01 at 13:04 -0700, Daniele Ceraolo Spurio wrote: Can you elaborate a bit more on what's the rationale for this? do you just want to avoid having too many inlines since the paths they're used in are not critical, or do you have some

Re: [Intel-gfx] [PATCH 5/6] drm/i915: Remove inline from sseu helper functions

2019-05-01 Thread Summers, Stuart
On Wed, 2019-05-01 at 13:04 -0700, Daniele Ceraolo Spurio wrote: > Can you elaborate a bit more on what's the rationale for this? do > you > just want to avoid having too many inlines since the paths they're > used > in are not critical, or do you have some more functional reason? This > is >

Re: [Intel-gfx] [PATCH 5/6] drm/i915: Remove inline from sseu helper functions

2019-05-01 Thread Daniele Ceraolo Spurio
Can you elaborate a bit more on what's the rationale for this? do you just want to avoid having too many inlines since the paths they're used in are not critical, or do you have some more functional reason? This is not a critic to the patch, I just want to understand where you're coming from

[Intel-gfx] [PATCH 5/6] drm/i915: Remove inline from sseu helper functions

2019-05-01 Thread Stuart Summers
Additionally, ensure these are all prefixed with intel_sseu_* to match the convention of other functions in i915. Signed-off-by: Stuart Summers --- drivers/gpu/drm/i915/gt/intel_sseu.c | 54 +++ drivers/gpu/drm/i915/gt/intel_sseu.h | 57 +++-

[Intel-gfx] [PATCH 5/6] drm/i915: Remove inline from sseu helper functions

2019-04-30 Thread Stuart Summers
Additionally, ensure these are all prefixed with intel_sseu_* to match the convention of other functions in i915. Signed-off-by: Stuart Summers --- drivers/gpu/drm/i915/gt/intel_sseu.c | 54 +++ drivers/gpu/drm/i915/gt/intel_sseu.h | 57 +++-