Re: [Intel-gfx] [PATCH 5/6] drm/rcar_du: changes to rcar-du driver resulting from drm_writeback_connector structure changes

2022-03-08 Thread Abhinav Kumar
Hi Suraj On 3/8/2022 6:30 AM, Kandpal, Suraj wrote: Hi Abhinav, Hi, Hi, Hi Abhinav, Hi Laurent Ok sure, I can take this up but I need to understand the proposal a little bit more before proceeding on this. So we will discuss this in another email where we specifically talk about the

Re: [Intel-gfx] [PATCH 5/6] drm/rcar_du: changes to rcar-du driver resulting from drm_writeback_connector structure changes

2022-03-08 Thread Kandpal, Suraj
Hi Abhinav, > > Hi, > >>> Hi, > > Hi Abhinav, > >> Hi Laurent > >> > >> Ok sure, I can take this up but I need to understand the proposal > >> a little bit more before proceeding on this. So we will discuss > >> this in another email where we specifically talk about the >

Re: [Intel-gfx] [PATCH 5/6] drm/rcar_du: changes to rcar-du driver resulting from drm_writeback_connector structure changes

2022-03-04 Thread Abhinav Kumar
Hi Suraj On 3/4/2022 6:16 AM, Kandpal, Suraj wrote: Hi, Hi, Hi Abhinav, Hi Laurent Ok sure, I can take this up but I need to understand the proposal a little bit more before proceeding on this. So we will discuss this in another email where we specifically talk about the connector changes.

Re: [Intel-gfx] [PATCH 5/6] drm/rcar_du: changes to rcar-du driver resulting from drm_writeback_connector structure changes

2022-03-04 Thread Kandpal, Suraj
Hi, > > Hi, > > > > Hi Abhinav, > > > > > Hi Laurent > > > > > > > > > > Ok sure, I can take this up but I need to understand the > > > > > proposal a little bit more before proceeding on this. So we will > > > > > discuss this in another email where we specifically talk about the > connector

Re: [Intel-gfx] [PATCH 5/6] drm/rcar_du: changes to rcar-du driver resulting from drm_writeback_connector structure changes

2022-03-04 Thread Dmitry Baryshkov
On Fri, 4 Mar 2022 at 13:47, Kandpal, Suraj wrote: > > Hi, > > > Hi Abhinav, > > > > Hi Laurent > > > > > > > > Ok sure, I can take this up but I need to understand the proposal a > > > > little bit more before proceeding on this. So we will discuss this > > > > in another email where we

Re: [Intel-gfx] [PATCH 5/6] drm/rcar_du: changes to rcar-du driver resulting from drm_writeback_connector structure changes

2022-03-04 Thread Dmitry Baryshkov
Hi, On Fri, 4 Mar 2022 at 12:56, Kandpal, Suraj wrote: > > Hi Abhinav, > > Hi Laurent > > > > Ok sure, I can take this up but I need to understand the proposal a little > > bit > > more before proceeding on this. So we will discuss this in another email > > where we specifically talk about the

Re: [Intel-gfx] [PATCH 5/6] drm/rcar_du: changes to rcar-du driver resulting from drm_writeback_connector structure changes

2022-03-04 Thread Kandpal, Suraj
Hi, > > Hi Abhinav, > > > Hi Laurent > > > > > > Ok sure, I can take this up but I need to understand the proposal a > > > little bit more before proceeding on this. So we will discuss this > > > in another email where we specifically talk about the connector changes. > > > > > > Also, I am

Re: [Intel-gfx] [PATCH 5/6] drm/rcar_du: changes to rcar-du driver resulting from drm_writeback_connector structure changes

2022-03-04 Thread Kandpal, Suraj
Hi Abhinav, > Hi Laurent > > Ok sure, I can take this up but I need to understand the proposal a little bit > more before proceeding on this. So we will discuss this in another email > where we specifically talk about the connector changes. > > Also, I am willing to take this up once the encoder

Re: [Intel-gfx] [PATCH 5/6] drm/rcar_du: changes to rcar-du driver resulting from drm_writeback_connector structure changes

2022-03-03 Thread Abhinav Kumar
On 3/2/2022 10:31 AM, Laurent Pinchart wrote: Hi Abhinav, On Wed, Mar 02, 2022 at 10:28:03AM -0800, Abhinav Kumar wrote: On 2/28/2022 5:42 AM, Laurent Pinchart wrote: On Mon, Feb 28, 2022 at 02:28:27PM +0200, Laurent Pinchart wrote: On Mon, Feb 28, 2022 at 02:09:15PM +0200, Jani Nikula

Re: [Intel-gfx] [PATCH 5/6] drm/rcar_du: changes to rcar-du driver resulting from drm_writeback_connector structure changes

2022-03-02 Thread Laurent Pinchart
Hi Abhinav, On Wed, Mar 02, 2022 at 10:28:03AM -0800, Abhinav Kumar wrote: > On 2/28/2022 5:42 AM, Laurent Pinchart wrote: > > On Mon, Feb 28, 2022 at 02:28:27PM +0200, Laurent Pinchart wrote: > >> On Mon, Feb 28, 2022 at 02:09:15PM +0200, Jani Nikula wrote: > >>> On Mon, 28 Feb 2022, Laurent

Re: [Intel-gfx] [PATCH 5/6] drm/rcar_du: changes to rcar-du driver resulting from drm_writeback_connector structure changes

2022-03-02 Thread Abhinav Kumar
On 2/28/2022 5:42 AM, Laurent Pinchart wrote: Hello, On Mon, Feb 28, 2022 at 02:28:27PM +0200, Laurent Pinchart wrote: On Mon, Feb 28, 2022 at 02:09:15PM +0200, Jani Nikula wrote: On Mon, 28 Feb 2022, Laurent Pinchart wrote: On Sat, Feb 26, 2022 at 10:27:59AM -0800, Rob Clark wrote: On

Re: [Intel-gfx] [PATCH 5/6] drm/rcar_du: changes to rcar-du driver resulting from drm_writeback_connector structure changes

2022-02-28 Thread Dmitry Baryshkov
On Mon, 28 Feb 2022 at 11:00, Laurent Pinchart wrote: > > Hi Suraj, > > On Sat, Feb 26, 2022 at 05:10:06AM +, Kandpal, Suraj wrote: > > Hi Abhinav, > > > > > Based on the discussion in this thread [1] , it seems like having > > > drm_encoder > > > as a pointer seems to have merits for both

Re: [Intel-gfx] [PATCH 5/6] drm/rcar_du: changes to rcar-du driver resulting from drm_writeback_connector structure changes

2022-02-28 Thread Laurent Pinchart
Hello, On Mon, Feb 28, 2022 at 02:28:27PM +0200, Laurent Pinchart wrote: > On Mon, Feb 28, 2022 at 02:09:15PM +0200, Jani Nikula wrote: > > On Mon, 28 Feb 2022, Laurent Pinchart wrote: > > > On Sat, Feb 26, 2022 at 10:27:59AM -0800, Rob Clark wrote: > > >> On Wed, Feb 2, 2022 at 7:41 AM Jani

Re: [Intel-gfx] [PATCH 5/6] drm/rcar_du: changes to rcar-du driver resulting from drm_writeback_connector structure changes

2022-02-28 Thread Laurent Pinchart
Hi Jani, On Mon, Feb 28, 2022 at 02:09:15PM +0200, Jani Nikula wrote: > On Mon, 28 Feb 2022, Laurent Pinchart wrote: > > On Sat, Feb 26, 2022 at 10:27:59AM -0800, Rob Clark wrote: > >> On Wed, Feb 2, 2022 at 7:41 AM Jani Nikula wrote: > >> > On Wed, 02 Feb 2022, Laurent Pinchart wrote: > >> > > On

Re: [Intel-gfx] [PATCH 5/6] drm/rcar_du: changes to rcar-du driver resulting from drm_writeback_connector structure changes

2022-02-28 Thread Jani Nikula
On Mon, 28 Feb 2022, Laurent Pinchart wrote: > Hi Rob, > > On Sat, Feb 26, 2022 at 10:27:59AM -0800, Rob Clark wrote: >> On Wed, Feb 2, 2022 at 7:41 AM Jani Nikula wrote: >> > On Wed, 02 Feb 2022, Laurent Pinchart wrote: >> > > On Wed, Feb 02, 2022 at 03:15:03PM +0200, Jani Nikula wrote: >> > >>

Re: [Intel-gfx] [PATCH 5/6] drm/rcar_du: changes to rcar-du driver resulting from drm_writeback_connector structure changes

2022-02-28 Thread Laurent Pinchart
Hi Dmitry, On Mon, Feb 28, 2022 at 11:07:41AM +0300, Dmitry Baryshkov wrote: > On Mon, 28 Feb 2022 at 11:00, Laurent Pinchart wrote: > > On Sat, Feb 26, 2022 at 05:10:06AM +, Kandpal, Suraj wrote: > > > Hi Abhinav, > > > > > > > Based on the discussion in this thread [1] , it seems like

Re: [Intel-gfx] [PATCH 5/6] drm/rcar_du: changes to rcar-du driver resulting from drm_writeback_connector structure changes

2022-02-28 Thread Laurent Pinchart
Hi Rob, On Sat, Feb 26, 2022 at 10:27:59AM -0800, Rob Clark wrote: > On Wed, Feb 2, 2022 at 7:41 AM Jani Nikula wrote: > > On Wed, 02 Feb 2022, Laurent Pinchart wrote: > > > On Wed, Feb 02, 2022 at 03:15:03PM +0200, Jani Nikula wrote: > > >> On Wed, 02 Feb 2022, Laurent Pinchart wrote: > > >> >

Re: [Intel-gfx] [PATCH 5/6] drm/rcar_du: changes to rcar-du driver resulting from drm_writeback_connector structure changes

2022-02-28 Thread Laurent Pinchart
Hi Suraj, On Sat, Feb 26, 2022 at 05:10:06AM +, Kandpal, Suraj wrote: > Hi Abhinav, > > > Based on the discussion in this thread [1] , it seems like having > > drm_encoder > > as a pointer seems to have merits for both of us and also in agreement with > > the folks on this thread and has a

Re: [Intel-gfx] [PATCH 5/6] drm/rcar_du: changes to rcar-du driver resulting from drm_writeback_connector structure changes

2022-02-26 Thread Rob Clark
On Wed, Feb 2, 2022 at 7:41 AM Jani Nikula wrote: > > On Wed, 02 Feb 2022, Laurent Pinchart > wrote: > > Hi Jani, > > > > On Wed, Feb 02, 2022 at 03:15:03PM +0200, Jani Nikula wrote: > >> On Wed, 02 Feb 2022, Laurent Pinchart wrote: > >> > On Wed, Feb 02, 2022 at 02:24:28PM +0530, Kandpal Suraj

Re: [Intel-gfx] [PATCH 5/6] drm/rcar_du: changes to rcar-du driver resulting from drm_writeback_connector structure changes

2022-02-25 Thread Kandpal, Suraj
Hi Abhinav, > Based on the discussion in this thread [1] , it seems like having drm_encoder > as a pointer seems to have merits for both of us and also in agreement with > the folks on this thread and has a better chance of an ack. > > However drm_connector is not. > > I had a brief look at

Re: [Intel-gfx] [PATCH 5/6] drm/rcar_du: changes to rcar-du driver resulting from drm_writeback_connector structure changes

2022-02-25 Thread Abhinav Kumar
Hi Suraj On 2/22/2022 10:17 PM, Kandpal, Suraj wrote: Hey, The connector/encoder funcs you do have to pass to drm_writeback_connector_init() can't use any of the shared driver infrastructure that assume a certain inheritance. See also my reply to Laurent [1]. It well might be that we all

Re: [Intel-gfx] [PATCH 5/6] drm/rcar_du: changes to rcar-du driver resulting from drm_writeback_connector structure changes

2022-02-23 Thread Abhinav Kumar
Hi Laurent Thanks for responding. On 2/21/2022 11:34 PM, Laurent Pinchart wrote: Hi Dmitry, On Tue, Feb 22, 2022 at 06:32:50AM +0300, Dmitry Baryshkov wrote: On Thu, 10 Feb 2022 at 07:59, Laurent Pinchart wrote: On Wed, Feb 09, 2022 at 05:40:29PM -0800, Abhinav Kumar wrote: Hi Laurent

Re: [Intel-gfx] [PATCH 5/6] drm/rcar_du: changes to rcar-du driver resulting from drm_writeback_connector structure changes

2022-02-22 Thread Kandpal, Suraj
Hey, > The connector/encoder funcs you do have to pass to > drm_writeback_connector_init() can't use any of the shared driver > infrastructure that assume a certain inheritance. > > See also my reply to Laurent [1]. > > > It well might be that we all misunderstand your design. Do you have a > >

Re: [Intel-gfx] [PATCH 5/6] drm/rcar_du: changes to rcar-du driver resulting from drm_writeback_connector structure changes

2022-02-22 Thread Dmitry Baryshkov
On Thu, 10 Feb 2022 at 07:59, Laurent Pinchart wrote: > > Hi Abhinav, > > On Wed, Feb 09, 2022 at 05:40:29PM -0800, Abhinav Kumar wrote: > > Hi Laurent > > > > Gentle reminder on this. > > I won't have time before next week I'm afraid. Laurent, another gentle ping. > > > On 2/6/2022 11:20 PM,

Re: [Intel-gfx] [PATCH 5/6] drm/rcar_du: changes to rcar-du driver resulting from drm_writeback_connector structure changes

2022-02-21 Thread Laurent Pinchart
Hi Dmitry, On Tue, Feb 22, 2022 at 06:32:50AM +0300, Dmitry Baryshkov wrote: > On Thu, 10 Feb 2022 at 07:59, Laurent Pinchart wrote: > > On Wed, Feb 09, 2022 at 05:40:29PM -0800, Abhinav Kumar wrote: > > > Hi Laurent > > > > > > Gentle reminder on this. > > > > I won't have time before next week

Re: [Intel-gfx] [PATCH 5/6] drm/rcar_du: changes to rcar-du driver resulting from drm_writeback_connector structure changes

2022-02-09 Thread Laurent Pinchart
Hi Abhinav, On Wed, Feb 09, 2022 at 05:40:29PM -0800, Abhinav Kumar wrote: > Hi Laurent > > Gentle reminder on this. I won't have time before next week I'm afraid. > On 2/6/2022 11:20 PM, Abhinav Kumar wrote: > > Hi Laurent > > > > On 2/6/2022 3:32 PM, Dmitry Baryshkov wrote: > >> On Wed, 2

Re: [Intel-gfx] [PATCH 5/6] drm/rcar_du: changes to rcar-du driver resulting from drm_writeback_connector structure changes

2022-02-09 Thread Abhinav Kumar
Hi Laurent Gentle reminder on this. Thanks Abhinav On 2/6/2022 11:20 PM, Abhinav Kumar wrote: Hi Laurent On 2/6/2022 3:32 PM, Dmitry Baryshkov wrote: On Wed, 2 Feb 2022 at 16:26, Laurent Pinchart wrote: Hi Jani, On Wed, Feb 02, 2022 at 03:15:03PM +0200, Jani Nikula wrote: On Wed, 02

Re: [Intel-gfx] [PATCH 5/6] drm/rcar_du: changes to rcar-du driver resulting from drm_writeback_connector structure changes

2022-02-08 Thread Dmitry Baryshkov
On Wed, 2 Feb 2022 at 16:26, Laurent Pinchart wrote: > > Hi Jani, > > On Wed, Feb 02, 2022 at 03:15:03PM +0200, Jani Nikula wrote: > > On Wed, 02 Feb 2022, Laurent Pinchart wrote: > > > On Wed, Feb 02, 2022 at 02:24:28PM +0530, Kandpal Suraj wrote: > > >> Changing rcar_du driver to accomadate the

Re: [Intel-gfx] [PATCH 5/6] drm/rcar_du: changes to rcar-du driver resulting from drm_writeback_connector structure changes

2022-02-06 Thread Abhinav Kumar
Hi Laurent On 2/6/2022 3:32 PM, Dmitry Baryshkov wrote: On Wed, 2 Feb 2022 at 16:26, Laurent Pinchart wrote: Hi Jani, On Wed, Feb 02, 2022 at 03:15:03PM +0200, Jani Nikula wrote: On Wed, 02 Feb 2022, Laurent Pinchart wrote: On Wed, Feb 02, 2022 at 02:24:28PM +0530, Kandpal Suraj wrote:

Re: [Intel-gfx] [PATCH 5/6] drm/rcar_du: changes to rcar-du driver resulting from drm_writeback_connector structure changes

2022-02-03 Thread Dmitry Baryshkov
On Wed, 2 Feb 2022 at 16:15, Jani Nikula wrote: > > On Wed, 02 Feb 2022, Laurent Pinchart > wrote: > > Hi Kandpal, > > > > Thank you for the patch. > > > > On Wed, Feb 02, 2022 at 02:24:28PM +0530, Kandpal Suraj wrote: > >> Changing rcar_du driver to accomadate the change of > >>

Re: [Intel-gfx] [PATCH 5/6] drm/rcar_du: changes to rcar-du driver resulting from drm_writeback_connector structure changes

2022-02-02 Thread Jani Nikula
On Wed, 02 Feb 2022, Dmitry Baryshkov wrote: > On Wed, 2 Feb 2022 at 16:15, Jani Nikula wrote: >> >> On Wed, 02 Feb 2022, Laurent Pinchart >> wrote: >> > Hi Kandpal, >> > >> > Thank you for the patch. >> > >> > On Wed, Feb 02, 2022 at 02:24:28PM +0530, Kandpal Suraj wrote: >> >> Changing

Re: [Intel-gfx] [PATCH 5/6] drm/rcar_du: changes to rcar-du driver resulting from drm_writeback_connector structure changes

2022-02-02 Thread Jani Nikula
On Wed, 02 Feb 2022, Laurent Pinchart wrote: > Hi Jani, > > On Wed, Feb 02, 2022 at 03:15:03PM +0200, Jani Nikula wrote: >> On Wed, 02 Feb 2022, Laurent Pinchart wrote: >> > On Wed, Feb 02, 2022 at 02:24:28PM +0530, Kandpal Suraj wrote: >> >> Changing rcar_du driver to accomadate the change of >>

Re: [Intel-gfx] [PATCH 5/6] drm/rcar_du: changes to rcar-du driver resulting from drm_writeback_connector structure changes

2022-02-02 Thread Ville Syrjälä
On Wed, Feb 02, 2022 at 03:15:03PM +0200, Jani Nikula wrote: > On Wed, 02 Feb 2022, Laurent Pinchart > wrote: > > Hi Kandpal, > > > > Thank you for the patch. > > > > On Wed, Feb 02, 2022 at 02:24:28PM +0530, Kandpal Suraj wrote: > >> Changing rcar_du driver to accomadate the change of > >>

Re: [Intel-gfx] [PATCH 5/6] drm/rcar_du: changes to rcar-du driver resulting from drm_writeback_connector structure changes

2022-02-02 Thread Laurent Pinchart
Hi Jani, On Wed, Feb 02, 2022 at 03:15:03PM +0200, Jani Nikula wrote: > On Wed, 02 Feb 2022, Laurent Pinchart wrote: > > On Wed, Feb 02, 2022 at 02:24:28PM +0530, Kandpal Suraj wrote: > >> Changing rcar_du driver to accomadate the change of > >> drm_writeback_connector.base and

Re: [Intel-gfx] [PATCH 5/6] drm/rcar_du: changes to rcar-du driver resulting from drm_writeback_connector structure changes

2022-02-02 Thread Jani Nikula
On Wed, 02 Feb 2022, Laurent Pinchart wrote: > Hi Kandpal, > > Thank you for the patch. > > On Wed, Feb 02, 2022 at 02:24:28PM +0530, Kandpal Suraj wrote: >> Changing rcar_du driver to accomadate the change of >> drm_writeback_connector.base and drm_writeback_connector.encoder >> to a pointer the

Re: [Intel-gfx] [PATCH 5/6] drm/rcar_du: changes to rcar-du driver resulting from drm_writeback_connector structure changes

2022-02-02 Thread Laurent Pinchart
Hi Kandpal, Thank you for the patch. On Wed, Feb 02, 2022 at 02:24:28PM +0530, Kandpal Suraj wrote: > Changing rcar_du driver to accomadate the change of > drm_writeback_connector.base and drm_writeback_connector.encoder > to a pointer the reason for which is explained in the > Patch(drm: add

[Intel-gfx] [PATCH 5/6] drm/rcar_du: changes to rcar-du driver resulting from drm_writeback_connector structure changes

2022-02-02 Thread Kandpal Suraj
Changing rcar_du driver to accomadate the change of drm_writeback_connector.base and drm_writeback_connector.encoder to a pointer the reason for which is explained in the Patch(drm: add writeback pointers to drm_connector). Signed-off-by: Kandpal Suraj --- drivers/gpu/drm/rcar-du/rcar_du_crtc.h