Re: [Intel-gfx] [PATCH 5/7] drm/i915: Initialize the aliasing ppgtt as part of global gtt

2014-08-04 Thread Daniel Vetter
On Fri, Aug 01, 2014 at 09:54:09AM +, Thierry, Michel wrote: > > > @@ -1766,6 +1771,20 @@ int i915_gem_setup_global_gtt(struct > > drm_device *dev, > > > /* And finally clear the reserved guard page */ > > > ggtt_vm->clear_range(ggtt_vm, end - PAGE_SIZE, PAGE_SIZE, true); > > > > > > + if (

Re: [Intel-gfx] [PATCH 5/7] drm/i915: Initialize the aliasing ppgtt as part of global gtt

2014-08-04 Thread Daniel Vetter
On Thu, Jul 31, 2014 at 07:15:52PM +0300, Ville Syrjälä wrote: > On Wed, Jul 30, 2014 at 09:42:02PM +0200, Daniel Vetter wrote: > > Stuffing this into the context setup code doesn't make a lot of sense. > > Also reusing the real ppgtt setup code makes even less sense since the > > aliasing ppgtt is

Re: [Intel-gfx] [PATCH 5/7] drm/i915: Initialize the aliasing ppgtt as part of global gtt

2014-08-01 Thread Thierry, Michel
> -Original Message- > From: Intel-gfx [mailto:intel-gfx-boun...@lists.freedesktop.org] On Behalf > Of Ville Syrjälä > Sent: Thursday, July 31, 2014 5:16 PM > To: Daniel Vetter > Cc: Intel Graphics Development > Subject: Re: [Intel-gfx] [PATCH 5/7] drm/i915: Initiali

Re: [Intel-gfx] [PATCH 5/7] drm/i915: Initialize the aliasing ppgtt as part of global gtt

2014-07-31 Thread Ville Syrjälä
On Wed, Jul 30, 2014 at 09:42:02PM +0200, Daniel Vetter wrote: > Stuffing this into the context setup code doesn't make a lot of sense. > Also reusing the real ppgtt setup code makes even less sense since the > aliasing ppgtt isn't a real address space. Leaving all that stuff > unitialized will mak

Re: [Intel-gfx] [PATCH 5/7] drm/i915: Initialize the aliasing ppgtt as part of global gtt

2014-07-31 Thread Thierry, Michel
> -Original Message- > From: Intel-gfx [mailto:intel-gfx-boun...@lists.freedesktop.org] On Behalf > Of Daniel Vetter > Sent: Wednesday, July 30, 2014 8:42 PM > To: Intel Graphics Development > Cc: Daniel Vetter > Subject: [Intel-gfx] [PATCH 5/7] drm/i915: Initialize

Re: [Intel-gfx] [PATCH 5/7] drm/i915: Initialize the aliasing ppgtt as part of global gtt

2014-07-31 Thread Daniel Vetter
On Thu, Jul 31, 2014 at 5:47 AM, Ben Widawsky wrote: > On Wed, Jul 30, 2014 at 08:46:11PM -0700, Ben Widawsky wrote: >> <1386367941-7131-76-git-send-email-benjamin.widaw...@intel.com> > > and > > <1386367941-7131-81-git-send-email-benjamin.widaw...@intel.com> Both of these are merged, so I really

Re: [Intel-gfx] [PATCH 5/7] drm/i915: Initialize the aliasing ppgtt as part of global gtt

2014-07-30 Thread Ben Widawsky
On Wed, Jul 30, 2014 at 08:47:03PM -0700, Ben Widawsky wrote: > On Wed, Jul 30, 2014 at 08:46:11PM -0700, Ben Widawsky wrote: > > <1386367941-7131-76-git-send-email-benjamin.widaw...@intel.com> > > and > > <1386367941-7131-81-git-send-email-benjamin.widaw...@intel.com> Oops, was looking at the w

Re: [Intel-gfx] [PATCH 5/7] drm/i915: Initialize the aliasing ppgtt as part of global gtt

2014-07-30 Thread Ben Widawsky
On Wed, Jul 30, 2014 at 08:46:11PM -0700, Ben Widawsky wrote: > <1386367941-7131-76-git-send-email-benjamin.widaw...@intel.com> and <1386367941-7131-81-git-send-email-benjamin.widaw...@intel.com> > > On Wed, Jul 30, 2014 at 09:42:02PM +0200, Daniel Vetter wrote: > > Stuffing this into the conte

Re: [Intel-gfx] [PATCH 5/7] drm/i915: Initialize the aliasing ppgtt as part of global gtt

2014-07-30 Thread Ben Widawsky
<1386367941-7131-76-git-send-email-benjamin.widaw...@intel.com> On Wed, Jul 30, 2014 at 09:42:02PM +0200, Daniel Vetter wrote: > Stuffing this into the context setup code doesn't make a lot of sense. > Also reusing the real ppgtt setup code makes even less sense since the > aliasing ppgtt isn't a

[Intel-gfx] [PATCH 5/7] drm/i915: Initialize the aliasing ppgtt as part of global gtt

2014-07-30 Thread Daniel Vetter
Stuffing this into the context setup code doesn't make a lot of sense. Also reusing the real ppgtt setup code makes even less sense since the aliasing ppgtt isn't a real address space. Leaving all that stuff unitialized will make sure that we catch any abusers promptly. This is also a prep work to