Re: [Intel-gfx] [PATCH i-g-t] intel_gpu_top: Fix cleanup on old kernels / unsupported GPU

2023-01-23 Thread Das, Nirmoy
On 1/23/2023 12:09 PM, Das, Nirmoy wrote: Hi Tvrtko, On 1/23/2023 11:24 AM, Tvrtko Ursulin wrote: On 20/01/2023 14:29, Das, Nirmoy wrote: Hi Tvrtko, On 1/19/2023 4:54 PM, Tvrtko Ursulin wrote: From: Tvrtko Ursulin Avoid trying to dereference null engines on exit when there are either

Re: [Intel-gfx] [PATCH i-g-t] intel_gpu_top: Fix cleanup on old kernels / unsupported GPU

2023-01-23 Thread Das, Nirmoy
On 1/19/2023 4:54 PM, Tvrtko Ursulin wrote: From: Tvrtko Ursulin Avoid trying to dereference null engines on exit when there are either none which are supported, or kernel does not have i915 PMU support. Signed-off-by: Tvrtko Ursulin Acked-by: Nirmoy Das --- tools/intel_gpu_top.c | 10

Re: [Intel-gfx] [PATCH i-g-t] intel_gpu_top: Fix cleanup on old kernels / unsupported GPU

2023-01-23 Thread Das, Nirmoy
Hi Tvrtko, On 1/23/2023 11:24 AM, Tvrtko Ursulin wrote: On 20/01/2023 14:29, Das, Nirmoy wrote: Hi Tvrtko, On 1/19/2023 4:54 PM, Tvrtko Ursulin wrote: From: Tvrtko Ursulin Avoid trying to dereference null engines on exit when there are either none which are supported, or kernel does not

Re: [Intel-gfx] [PATCH i-g-t] intel_gpu_top: Fix cleanup on old kernels / unsupported GPU

2023-01-23 Thread Tvrtko Ursulin
On 20/01/2023 14:29, Das, Nirmoy wrote: Hi Tvrtko, On 1/19/2023 4:54 PM, Tvrtko Ursulin wrote: From: Tvrtko Ursulin Avoid trying to dereference null engines on exit when there are either none which are supported, or kernel does not have i915 PMU support. Signed-off-by: Tvrtko Ursulin ---

Re: [Intel-gfx] [PATCH i-g-t] intel_gpu_top: Fix cleanup on old kernels / unsupported GPU

2023-01-20 Thread Das, Nirmoy
Hi Tvrtko, On 1/19/2023 4:54 PM, Tvrtko Ursulin wrote: From: Tvrtko Ursulin Avoid trying to dereference null engines on exit when there are either none which are supported, or kernel does not have i915 PMU support. Signed-off-by: Tvrtko Ursulin --- tools/intel_gpu_top.c | 10 +++---

[Intel-gfx] [PATCH i-g-t] intel_gpu_top: Fix cleanup on old kernels / unsupported GPU

2023-01-19 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Avoid trying to dereference null engines on exit when there are either none which are supported, or kernel does not have i915 PMU support. Signed-off-by: Tvrtko Ursulin --- tools/intel_gpu_top.c | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git