[Intel-gfx] [PATCH i-g-t] tests/gem_mmap_gtt(huge_bo): Use pread more to verify domain transfer.

2015-05-06 Thread Joonas Lahtinen
Use pread right after moving out of CPU domain to verify all writes flushed correctly. Due to extended usage, add own buffer. Signed-off-by: Joonas Lahtinen joonas.lahti...@linux.intel.com --- tests/gem_mmap_gtt.c | 28 +--- 1 file changed, 21 insertions(+), 7

Re: [Intel-gfx] [PATCH i-g-t] tests/gem_mmap_gtt(huge_bo): Use pread more to verify domain transfer.

2015-05-06 Thread Joonas Lahtinen
On ke, 2015-05-06 at 14:15 +0100, Chris Wilson wrote: On Wed, May 06, 2015 at 03:31:10PM +0300, Joonas Lahtinen wrote: Use pread right after moving out of CPU domain to verify all writes flushed correctly. Wrong test, see gem_pread. Adding extra work may have the unintended

Re: [Intel-gfx] [PATCH i-g-t] tests/gem_mmap_gtt(huge_bo): Use pread more to verify domain transfer.

2015-05-06 Thread Chris Wilson
On Wed, May 06, 2015 at 03:31:10PM +0300, Joonas Lahtinen wrote: Use pread right after moving out of CPU domain to verify all writes flushed correctly. Wrong test, see gem_pread. Adding extra work may have the unintended side-effects of masking bugs. If you want to mix access modes, call it a

Re: [Intel-gfx] [PATCH i-g-t] tests/gem_mmap_gtt(huge_bo): Use pread more to verify domain transfer.

2015-05-06 Thread Chris Wilson
On Wed, May 06, 2015 at 04:22:23PM +0300, Joonas Lahtinen wrote: On ke, 2015-05-06 at 14:15 +0100, Chris Wilson wrote: On Wed, May 06, 2015 at 03:31:10PM +0300, Joonas Lahtinen wrote: Use pread right after moving out of CPU domain to verify all writes flushed correctly. Wrong

Re: [Intel-gfx] [PATCH i-g-t] tests/gem_mmap_gtt(huge_bo): Use pread more to verify domain transfer.

2015-05-06 Thread Joonas Lahtinen
On ke, 2015-05-06 at 14:29 +0100, Chris Wilson wrote: On Wed, May 06, 2015 at 04:22:23PM +0300, Joonas Lahtinen wrote: On ke, 2015-05-06 at 14:15 +0100, Chris Wilson wrote: On Wed, May 06, 2015 at 03:31:10PM +0300, Joonas Lahtinen wrote: Use pread right after moving out of CPU