Re: [Intel-gfx] [PATCH i-g-t] tests/pm_rpm: Fix CRASH on machines that lack LLC

2016-03-02 Thread Imre Deak
On ke, 2016-03-02 at 15:28 +, Chris Wilson wrote: > On Wed, Mar 02, 2016 at 05:01:19PM +0200, Imre Deak wrote: > [...] > Hmm, this file has a noticeable lack of GEM domain management. E.g. > gem_mmap_subtest() will only work by happenstance on !llc with > gtt_mmap=false. > > To test the

Re: [Intel-gfx] [PATCH i-g-t] tests/pm_rpm: Fix CRASH on machines that lack LLC

2016-03-02 Thread Chris Wilson
On Wed, Mar 02, 2016 at 05:01:19PM +0200, Imre Deak wrote: > Ah right, I missed that, thanks for explaining. But we still need to > make sure the device is suspended before the set-cache-level call, that > is an initial disable_all_screens() and then wait_for_suspended() > before calling

Re: [Intel-gfx] [PATCH i-g-t] tests/pm_rpm: Fix CRASH on machines that lack LLC

2016-03-02 Thread Imre Deak
On ke, 2016-03-02 at 14:49 +, Chris Wilson wrote: > On Wed, Mar 02, 2016 at 04:41:54PM +0200, Imre Deak wrote: > > On ke, 2016-03-02 at 14:37 +, Chris Wilson wrote: > > > On Wed, Mar 02, 2016 at 04:32:41PM +0200, Imre Deak wrote: > > > > On ke, 2016-03-02 at 14:04 +, Chris Wilson

Re: [Intel-gfx] [PATCH i-g-t] tests/pm_rpm: Fix CRASH on machines that lack LLC

2016-03-02 Thread Chris Wilson
On Wed, Mar 02, 2016 at 04:41:54PM +0200, Imre Deak wrote: > On ke, 2016-03-02 at 14:37 +, Chris Wilson wrote: > > On Wed, Mar 02, 2016 at 04:32:41PM +0200, Imre Deak wrote: > > > On ke, 2016-03-02 at 14:04 +, Chris Wilson wrote: > > > > On Wed, Mar 02, 2016 at 03:55:56PM +0200, David

Re: [Intel-gfx] [PATCH i-g-t] tests/pm_rpm: Fix CRASH on machines that lack LLC

2016-03-02 Thread Imre Deak
On ke, 2016-03-02 at 14:37 +, Chris Wilson wrote: > On Wed, Mar 02, 2016 at 04:32:41PM +0200, Imre Deak wrote: > > On ke, 2016-03-02 at 14:04 +, Chris Wilson wrote: > > > On Wed, Mar 02, 2016 at 03:55:56PM +0200, David Weinehall wrote: > > > > On Wed, Mar 02, 2016 at 01:27:06PM +,

Re: [Intel-gfx] [PATCH i-g-t] tests/pm_rpm: Fix CRASH on machines that lack LLC

2016-03-02 Thread David Weinehall
On Wed, Mar 02, 2016 at 02:04:58PM +, Chris Wilson wrote: > On Wed, Mar 02, 2016 at 03:55:56PM +0200, David Weinehall wrote: > > On Wed, Mar 02, 2016 at 01:27:06PM +, Chris Wilson wrote: > > > On Wed, Mar 02, 2016 at 03:11:57PM +0200, David Weinehall wrote: > > > > On machines that lack an

Re: [Intel-gfx] [PATCH i-g-t] tests/pm_rpm: Fix CRASH on machines that lack LLC

2016-03-02 Thread Chris Wilson
On Wed, Mar 02, 2016 at 04:32:41PM +0200, Imre Deak wrote: > On ke, 2016-03-02 at 14:04 +, Chris Wilson wrote: > > On Wed, Mar 02, 2016 at 03:55:56PM +0200, David Weinehall wrote: > > > On Wed, Mar 02, 2016 at 01:27:06PM +, Chris Wilson wrote: > > > > On Wed, Mar 02, 2016 at 03:11:57PM

Re: [Intel-gfx] [PATCH i-g-t] tests/pm_rpm: Fix CRASH on machines that lack LLC

2016-03-02 Thread Imre Deak
On ke, 2016-03-02 at 14:04 +, Chris Wilson wrote: > On Wed, Mar 02, 2016 at 03:55:56PM +0200, David Weinehall wrote: > > On Wed, Mar 02, 2016 at 01:27:06PM +, Chris Wilson wrote: > > > On Wed, Mar 02, 2016 at 03:11:57PM +0200, David Weinehall wrote: > > > > On machines that lack an LLC the

Re: [Intel-gfx] [PATCH i-g-t] tests/pm_rpm: Fix CRASH on machines that lack LLC

2016-03-02 Thread Chris Wilson
On Wed, Mar 02, 2016 at 03:55:56PM +0200, David Weinehall wrote: > On Wed, Mar 02, 2016 at 01:27:06PM +, Chris Wilson wrote: > > On Wed, Mar 02, 2016 at 03:11:57PM +0200, David Weinehall wrote: > > > On machines that lack an LLC the pm-caching subtest will > > > terminate with sigbus and thus

Re: [Intel-gfx] [PATCH i-g-t] tests/pm_rpm: Fix CRASH on machines that lack LLC

2016-03-02 Thread David Weinehall
On Wed, Mar 02, 2016 at 01:27:06PM +, Chris Wilson wrote: > On Wed, Mar 02, 2016 at 03:11:57PM +0200, David Weinehall wrote: > > On machines that lack an LLC the pm-caching subtest will > > terminate with sigbus and thus CRASH during the > > I915_CACHING_CACHED iteration. This patch adds a

Re: [Intel-gfx] [PATCH i-g-t] tests/pm_rpm: Fix CRASH on machines that lack LLC

2016-03-02 Thread Chris Wilson
On Wed, Mar 02, 2016 at 03:11:57PM +0200, David Weinehall wrote: > On machines that lack an LLC the pm-caching subtest will > terminate with sigbus and thus CRASH during the > I915_CACHING_CACHED iteration. This patch adds a check for > this condition and skips that iteration. you can delete the

[Intel-gfx] [PATCH i-g-t] tests/pm_rpm: Fix CRASH on machines that lack LLC

2016-03-02 Thread David Weinehall
On machines that lack an LLC the pm-caching subtest will terminate with sigbus and thus CRASH during the I915_CACHING_CACHED iteration. This patch adds a check for this condition and skips that iteration. Signed-off-by: David Weinehall --- tests/pm_rpm.c | 10