Re: [Intel-gfx] [PATCH i-g-t v2 05/17] lib/kunit: Fix illegal igt_fail() calls inside subtest body

2023-09-13 Thread Janusz Krzysztofik
On Monday, 11 September 2023 13:57:29 CEST Mauro Carvalho Chehab wrote: > On Mon, 11 Sep 2023 11:28:32 +0200 > Janusz Krzysztofik wrote: > > > Hi Mauro, > > > > Thanks for review. > > > > On Monday, 11 September 2023 10:52:51 CEST Mauro Carvalho Chehab wrote: > > > On Fri, 8 Sep 2023 14:32:39

Re: [Intel-gfx] [PATCH i-g-t v2 05/17] lib/kunit: Fix illegal igt_fail() calls inside subtest body

2023-09-11 Thread Mauro Carvalho Chehab
On Mon, 11 Sep 2023 11:28:32 +0200 Janusz Krzysztofik wrote: > Hi Mauro, > > Thanks for review. > > On Monday, 11 September 2023 10:52:51 CEST Mauro Carvalho Chehab wrote: > > On Fri, 8 Sep 2023 14:32:39 +0200 > > Janusz Krzysztofik wrote: > > > > > In a body of a subtest with dynamic

Re: [Intel-gfx] [PATCH i-g-t v2 05/17] lib/kunit: Fix illegal igt_fail() calls inside subtest body

2023-09-11 Thread Janusz Krzysztofik
Hi Mauro, Thanks for review. On Monday, 11 September 2023 10:52:51 CEST Mauro Carvalho Chehab wrote: > On Fri, 8 Sep 2023 14:32:39 +0200 > Janusz Krzysztofik wrote: > > > In a body of a subtest with dynamic sub-subtests, it is illegal to call > > igt_fail() and its variants from outside of a

Re: [Intel-gfx] [PATCH i-g-t v2 05/17] lib/kunit: Fix illegal igt_fail() calls inside subtest body

2023-09-11 Thread Mauro Carvalho Chehab
On Fri, 8 Sep 2023 14:32:39 +0200 Janusz Krzysztofik wrote: > In a body of a subtest with dynamic sub-subtests, it is illegal to call > igt_fail() and its variants from outside of a dynamic sub-subtest body. > On the other hand, it is perfectly legal to call either igt_skip() and > friends or

[Intel-gfx] [PATCH i-g-t v2 05/17] lib/kunit: Fix illegal igt_fail() calls inside subtest body

2023-09-08 Thread Janusz Krzysztofik
In a body of a subtest with dynamic sub-subtests, it is illegal to call igt_fail() and its variants from outside of a dynamic sub-subtest body. On the other hand, it is perfectly legal to call either igt_skip() and friends or __igt_abort() or its variant from there. In the current implementation