Re: [Intel-gfx] [PATCH i-g-t v4 01/13] lib/sw_sync: Add helper functions for managing synchronization primitives

2016-09-15 Thread Gustavo Padovan
2016-09-15 Robert Foss : > > > On 2016-09-15 02:35 PM, Robert Foss wrote: > > > > > > On 2016-09-15 02:46 AM, Chris Wilson wrote: > > > On Wed, Sep 14, 2016 at 11:04:30AM -0400, robert.f...@collabora.com > > > wrote: > > > > +void sw_sync_timeline_inc(int fd,

Re: [Intel-gfx] [PATCH i-g-t v4 01/13] lib/sw_sync: Add helper functions for managing synchronization primitives

2016-09-15 Thread Robert Foss
On 2016-09-15 02:35 PM, Robert Foss wrote: On 2016-09-15 02:46 AM, Chris Wilson wrote: On Wed, Sep 14, 2016 at 11:04:30AM -0400, robert.f...@collabora.com wrote: +void sw_sync_timeline_inc(int fd, uint32_t count) +{ +uint32_t arg = count; + +if (fd == 0) +return; But fd =

Re: [Intel-gfx] [PATCH i-g-t v4 01/13] lib/sw_sync: Add helper functions for managing synchronization primitives

2016-09-15 Thread Robert Foss
On 2016-09-15 02:46 AM, Chris Wilson wrote: On Wed, Sep 14, 2016 at 11:04:30AM -0400, robert.f...@collabora.com wrote: +void sw_sync_timeline_inc(int fd, uint32_t count) +{ + uint32_t arg = count; + + if (fd == 0) + return; But fd = 0 is a valid fd, and might be a

Re: [Intel-gfx] [PATCH i-g-t v4 01/13] lib/sw_sync: Add helper functions for managing synchronization primitives

2016-09-15 Thread Chris Wilson
On Wed, Sep 14, 2016 at 11:04:30AM -0400, robert.f...@collabora.com wrote: > +void sw_sync_timeline_inc(int fd, uint32_t count) > +{ > + uint32_t arg = count; > + > + if (fd == 0) > + return; But fd = 0 is a valid fd, and might be a timeline somewhere. Did you mean count == 0

[Intel-gfx] [PATCH i-g-t v4 01/13] lib/sw_sync: Add helper functions for managing synchronization primitives

2016-09-14 Thread robert . foss
From: Robert Foss Base functions to help testing the Sync File Framework (explicit fencing mechanism ported from Android). These functions allow you to create, use and destroy timelines and fences. Signed-off-by: Robert Foss Signed-off-by: