Re: [Intel-gfx] [PATCH igt] lib/kmod: Fix error reporting for kmod load/unload

2017-08-28 Thread Petri Latvala
On Fri, Aug 25, 2017 at 06:28:36PM +0100, Chris Wilson wrote: > A "return -err ? err < 0 : err" managed to slip through. So if err was > set, we returned 0 or 1 based on sign, or 0 if err was zero. > > If err is negative, we want treat it as an error, so report it back > to the caller, all other

[Intel-gfx] [PATCH igt] lib/kmod: Fix error reporting for kmod load/unload

2017-08-25 Thread Chris Wilson
A "return -err ? err < 0 : err" managed to slip through. So if err was set, we returned 0 or 1 based on sign, or 0 if err was zero. If err is negative, we want treat it as an error, so report it back to the caller, all other values were a success, so convert those to 0. This should actually be