Re: [Intel-gfx] [PATCH igt] lib: add igt_debugfs_read()

2015-07-23 Thread Daniel Vetter
On Wed, Jul 22, 2015 at 9:11 PM, Paulo Zanoni przan...@gmail.com wrote: +#define igt_debugfs_read(filename, buf) \ + __igt_debugfs_read((filename), (buf), sizeof(buf)) gtkdoc for this one would be nice too, along the lines of Convenience wrapper macro for __igt_debugfs_read ...

[Intel-gfx] [PATCH igt] lib: add igt_debugfs_read()

2015-07-22 Thread Paulo Zanoni
From: Paulo Zanoni paulo.r.zan...@intel.com A helpful function for when you want to read a whole debugfs file to a string and don't want to worry about opening and closing file descriptors and asserting buffer sizes. We've been using this already for kms_frontbuffer_tracking and kms_fbcon_fbt,

Re: [Intel-gfx] [PATCH igt] lib: add igt_debugfs_read()

2015-07-21 Thread Daniel Vetter
On Tue, Jul 21, 2015 at 02:08:23PM -0300, Paulo Zanoni wrote: From: Paulo Zanoni paulo.r.zan...@intel.com A helpful function for when you want to read a whole debugfs file to a string and don't want to worry about opening and closing file descriptors and asserting buffer sizes. We've been

[Intel-gfx] [PATCH igt] lib: add igt_debugfs_read()

2015-07-21 Thread Paulo Zanoni
From: Paulo Zanoni paulo.r.zan...@intel.com A helpful function for when you want to read a whole debugfs file to a string and don't want to worry about opening and closing file descriptors and asserting buffer sizes. We've been using this already for kms_frontbuffer_tracking and kms_fbcon_fbt,

Re: [Intel-gfx] [PATCH igt] lib: add igt_debugfs_read()

2015-07-21 Thread Paulo Zanoni
2015-07-21 14:43 GMT-03:00 Daniel Vetter dan...@ffwll.ch: On Tue, Jul 21, 2015 at 02:08:23PM -0300, Paulo Zanoni wrote: From: Paulo Zanoni paulo.r.zan...@intel.com A helpful function for when you want to read a whole debugfs file to a string and don't want to worry about opening and closing