Re: [Intel-gfx] [PATCH v11 3/4] drm/i915: Use new CRC debugfs API

2016-11-16 Thread Daniel Vetter
On Wed, Nov 16, 2016 at 04:08:30PM +0200, Jani Nikula wrote: > On Wed, 16 Nov 2016, Tomeu Vizoso wrote: > > On 16 November 2016 at 13:58, Jani Nikula > > wrote: > >> On Wed, 16 Nov 2016, Tomeu Vizoso wrote: >

Re: [Intel-gfx] [PATCH v11 3/4] drm/i915: Use new CRC debugfs API

2016-11-16 Thread Jani Nikula
On Wed, 16 Nov 2016, Tomeu Vizoso wrote: > On 16 November 2016 at 13:58, Jani Nikula wrote: >> On Wed, 16 Nov 2016, Tomeu Vizoso wrote: >>> On 15 November 2016 at 09:27, Jani Nikula

Re: [Intel-gfx] [PATCH v11 3/4] drm/i915: Use new CRC debugfs API

2016-11-16 Thread Tomeu Vizoso
On 16 November 2016 at 13:58, Jani Nikula wrote: > On Wed, 16 Nov 2016, Tomeu Vizoso wrote: >> On 15 November 2016 at 09:27, Jani Nikula >> wrote: >>> On Tue, 15 Nov 2016, David Weinehall

Re: [Intel-gfx] [PATCH v11 3/4] drm/i915: Use new CRC debugfs API

2016-11-16 Thread Jani Nikula
On Wed, 16 Nov 2016, Tomeu Vizoso wrote: > On 15 November 2016 at 09:27, Jani Nikula wrote: >> On Tue, 15 Nov 2016, David Weinehall wrote: >>> On Mon, Nov 14, 2016 at 12:44:25PM +0200, Jani Nikula wrote: On Thu, 06

Re: [Intel-gfx] [PATCH v11 3/4] drm/i915: Use new CRC debugfs API

2016-11-16 Thread Tomeu Vizoso
On 15 November 2016 at 09:27, Jani Nikula wrote: > On Tue, 15 Nov 2016, David Weinehall wrote: >> On Mon, Nov 14, 2016 at 12:44:25PM +0200, Jani Nikula wrote: >>> On Thu, 06 Oct 2016, Tomeu Vizoso wrote: >>> > diff --git

Re: [Intel-gfx] [PATCH v11 3/4] drm/i915: Use new CRC debugfs API

2016-11-15 Thread Jani Nikula
On Tue, 15 Nov 2016, David Weinehall wrote: > On Mon, Nov 14, 2016 at 12:44:25PM +0200, Jani Nikula wrote: >> On Thu, 06 Oct 2016, Tomeu Vizoso wrote: >> > diff --git a/drivers/gpu/drm/i915/intel_display.c >> > b/drivers/gpu/drm/i915/intel_display.c

Re: [Intel-gfx] [PATCH v11 3/4] drm/i915: Use new CRC debugfs API

2016-11-14 Thread David Weinehall
On Mon, Nov 14, 2016 at 12:44:25PM +0200, Jani Nikula wrote: > On Thu, 06 Oct 2016, Tomeu Vizoso wrote: > > diff --git a/drivers/gpu/drm/i915/intel_display.c > > b/drivers/gpu/drm/i915/intel_display.c > > index 23a6c7213eca..7412a05fa5d9 100644 > > ---

Re: [Intel-gfx] [PATCH v11 3/4] drm/i915: Use new CRC debugfs API

2016-11-14 Thread Jani Nikula
On Thu, 06 Oct 2016, Tomeu Vizoso wrote: > diff --git a/drivers/gpu/drm/i915/intel_display.c > b/drivers/gpu/drm/i915/intel_display.c > index 23a6c7213eca..7412a05fa5d9 100644 > --- a/drivers/gpu/drm/i915/intel_display.c > +++ b/drivers/gpu/drm/i915/intel_display.c >

[Intel-gfx] [PATCH v11 3/4] drm/i915: Use new CRC debugfs API

2016-10-06 Thread Tomeu Vizoso
The core provides now an ABI to userspace for generation of frame CRCs, so implement the ->set_crc_source() callback and reuse as much code as possible with the previous ABI implementation. When handling the pageflip interrupt, we skip 1 or 2 frames depending on the HW because they contain wrong