Re: [Intel-gfx] [PATCH v15 3/5] drm/i915: Introduce parameterized DBUF_CTL

2020-01-21 Thread Ville Syrjälä
On Mon, Jan 20, 2020 at 02:21:01PM +0200, Stanislav Lisovskiy wrote: > Now start using parameterized DBUF_CTL instead > of hardcoded, this would allow shorter access > functions when reading or storing entire state. > > Tried to implement it in a MMIO_PIPE manner, however > DBUF_CTL1 address is hi

[Intel-gfx] [PATCH v15 3/5] drm/i915: Introduce parameterized DBUF_CTL

2020-01-20 Thread Stanislav Lisovskiy
Now start using parameterized DBUF_CTL instead of hardcoded, this would allow shorter access functions when reading or storing entire state. Tried to implement it in a MMIO_PIPE manner, however DBUF_CTL1 address is higher than DBUF_CTL2, which implies that we have to now subtract from base rather