Re: [Intel-gfx] [PATCH v2] drm/i915/dp/mst: Fix MST logic in intel_dp_long_pulse()

2016-04-12 Thread Lyude
I'm going to take back the NAK on this, apparently this hotplugging issue has been around longer then this patchset. Reviewed-by: Lyude On Tue, 2016-04-12 at 10:11 +0300, Ander Conselvan De Oliveira wrote: > On Mon, 2016-04-11 at 10:11 -0700, Jim Bride wrote: > > > > In

Re: [Intel-gfx] [PATCH v2] drm/i915/dp/mst: Fix MST logic in intel_dp_long_pulse()

2016-04-12 Thread Ander Conselvan De Oliveira
On Mon, 2016-04-11 at 10:11 -0700, Jim Bride wrote: > In commit 7d23e3c3 ("drm/i915: Cleaning up intel_dp_hpd_pulse") some > much needed clean-up was done, but unfortunately part of the change > broke DP MST. The real issue was setting the connector state to > disconnected in the MST case, which

Re: [Intel-gfx] [PATCH v2] drm/i915/dp/mst: Fix MST logic in intel_dp_long_pulse()

2016-04-11 Thread Lyude Paul
NAK. Try plugging in an MST display, suspending the machine, then resuming it. Hotplugging still breaks (which I've traced down to this patch) I wouldn't worry about fixing this up. I'm probably going to be sending a revert for this anyway soon along with probably some of the other patches. On

[Intel-gfx] [PATCH v2] drm/i915/dp/mst: Fix MST logic in intel_dp_long_pulse()

2016-04-11 Thread Jim Bride
In commit 7d23e3c3 ("drm/i915: Cleaning up intel_dp_hpd_pulse") some much needed clean-up was done, but unfortunately part of the change broke DP MST. The real issue was setting the connector state to disconnected in the MST case, which is good, but the code then (after a goto) checks if the