Re: [Intel-gfx] [PATCH v2] drm/i915/execlists: Skip forcewake for ELSP submission

2018-01-22 Thread Tvrtko Ursulin
On 22/01/2018 17:17, Chris Wilson wrote: Quoting Tvrtko Ursulin (2018-01-22 16:59:21) On 22/01/2018 10:07, Chris Wilson wrote: Now that we can read the CSB from the HWSP, we may avoid having to perform mmio reads entirely and so forgo the rigmarole of the forcewake dance. v2: Include

Re: [Intel-gfx] [PATCH v2] drm/i915/execlists: Skip forcewake for ELSP submission

2018-01-22 Thread Chris Wilson
Quoting Tvrtko Ursulin (2018-01-22 16:59:21) > > On 22/01/2018 10:07, Chris Wilson wrote: > > Now that we can read the CSB from the HWSP, we may avoid having to > > perform mmio reads entirely and so forgo the rigmarole of the forcewake > > dance. > > > > v2: Include forcewake hint for GEM_TRACE

Re: [Intel-gfx] [PATCH v2] drm/i915/execlists: Skip forcewake for ELSP submission

2018-01-22 Thread Tvrtko Ursulin
On 22/01/2018 10:07, Chris Wilson wrote: Now that we can read the CSB from the HWSP, we may avoid having to perform mmio reads entirely and so forgo the rigmarole of the forcewake dance. v2: Include forcewake hint for GEM_TRACE readback of mmio. If we don't hold fw ourselves, the reads may

[Intel-gfx] [PATCH v2] drm/i915/execlists: Skip forcewake for ELSP submission

2018-01-22 Thread Chris Wilson
Now that we can read the CSB from the HWSP, we may avoid having to perform mmio reads entirely and so forgo the rigmarole of the forcewake dance. v2: Include forcewake hint for GEM_TRACE readback of mmio. If we don't hold fw ourselves, the reads may return garbage. Signed-off-by: Chris Wilson