Re: [Intel-gfx] [PATCH v2] drm/i915: Don't enable IPS when pixel rate exceeds 95% of cdclk

2015-05-20 Thread Rodrigo Vivi
I'm convinced Unclaimed regs Paulo saw came from somewhere else since I just got it with pm_rpm rte with no patch applied So I'd suggest to merge this patch... Although it also doesn't fix the flicker I see here so the bug would still be open... Anyway, Reviewed-by: Rodrigo Vivi

Re: [Intel-gfx] [PATCH v2] drm/i915: Don't enable IPS when pixel rate exceeds 95% of cdclk

2015-05-20 Thread Paulo Zanoni
2015-05-20 17:40 GMT-03:00 Rodrigo Vivi rodrigo.v...@gmail.com: I'm convinced Unclaimed regs Paulo saw came from somewhere else since I just got it with pm_rpm rte with no patch applied So I'd suggest to merge this patch... Although it also doesn't fix the flicker I see here so the bug

Re: [Intel-gfx] [PATCH v2] drm/i915: Don't enable IPS when pixel rate exceeds 95% of cdclk

2014-09-18 Thread Jani Nikula
On Wed, 17 Sep 2014, Ville Syrjälä ville.syrj...@linux.intel.com wrote: On Wed, Sep 17, 2014 at 11:10:48AM -0300, Paulo Zanoni wrote: 2014-09-17 11:05 GMT-03:00 Paulo Zanoni przan...@gmail.com: 2014-09-15 4:22 GMT-03:00 Jani Nikula jani.nik...@linux.intel.com: On Fri, 12 Sep 2014, Ville

Re: [Intel-gfx] [PATCH v2] drm/i915: Don't enable IPS when pixel rate exceeds 95% of cdclk

2014-09-17 Thread Paulo Zanoni
2014-09-15 4:22 GMT-03:00 Jani Nikula jani.nik...@linux.intel.com: On Fri, 12 Sep 2014, Ville Syrjälä ville.syrj...@linux.intel.com wrote: On Fri, Sep 12, 2014 at 04:42:33PM +0100, Chris Wilson wrote: On Fri, Sep 12, 2014 at 05:01:57PM +0300, ville.syrj...@linux.intel.com wrote: From: Ville

Re: [Intel-gfx] [PATCH v2] drm/i915: Don't enable IPS when pixel rate exceeds 95% of cdclk

2014-09-17 Thread Paulo Zanoni
2014-09-17 11:05 GMT-03:00 Paulo Zanoni przan...@gmail.com: 2014-09-15 4:22 GMT-03:00 Jani Nikula jani.nik...@linux.intel.com: On Fri, 12 Sep 2014, Ville Syrjälä ville.syrj...@linux.intel.com wrote: On Fri, Sep 12, 2014 at 04:42:33PM +0100, Chris Wilson wrote: On Fri, Sep 12, 2014 at

Re: [Intel-gfx] [PATCH v2] drm/i915: Don't enable IPS when pixel rate exceeds 95% of cdclk

2014-09-17 Thread Ville Syrjälä
On Wed, Sep 17, 2014 at 11:10:48AM -0300, Paulo Zanoni wrote: 2014-09-17 11:05 GMT-03:00 Paulo Zanoni przan...@gmail.com: 2014-09-15 4:22 GMT-03:00 Jani Nikula jani.nik...@linux.intel.com: On Fri, 12 Sep 2014, Ville Syrjälä ville.syrj...@linux.intel.com wrote: On Fri, Sep 12, 2014 at

Re: [Intel-gfx] [PATCH v2] drm/i915: Don't enable IPS when pixel rate exceeds 95% of cdclk

2014-09-15 Thread Jani Nikula
On Fri, 12 Sep 2014, Ville Syrjälä ville.syrj...@linux.intel.com wrote: On Fri, Sep 12, 2014 at 04:42:33PM +0100, Chris Wilson wrote: On Fri, Sep 12, 2014 at 05:01:57PM +0300, ville.syrj...@linux.intel.com wrote: From: Ville Syrjälä ville.syrj...@linux.intel.com Bspec says we shouldn't

[Intel-gfx] [PATCH v2] drm/i915: Don't enable IPS when pixel rate exceeds 95% of cdclk

2014-09-12 Thread ville . syrjala
From: Ville Syrjälä ville.syrj...@linux.intel.com Bspec says we shouldn't enable IPS on BDW when the pipe pixel rate exceeds 95% of the core display clock. Apparently this can cause underruns. There's no similar restriction listed for HSW, so leave that one alone for now. v2: Add

Re: [Intel-gfx] [PATCH v2] drm/i915: Don't enable IPS when pixel rate exceeds 95% of cdclk

2014-09-12 Thread Chris Wilson
On Fri, Sep 12, 2014 at 05:01:57PM +0300, ville.syrj...@linux.intel.com wrote: From: Ville Syrjälä ville.syrj...@linux.intel.com Bspec says we shouldn't enable IPS on BDW when the pipe pixel rate exceeds 95% of the core display clock. Apparently this can cause underruns. There's no

Re: [Intel-gfx] [PATCH v2] drm/i915: Don't enable IPS when pixel rate exceeds 95% of cdclk

2014-09-12 Thread Ville Syrjälä
On Fri, Sep 12, 2014 at 04:42:33PM +0100, Chris Wilson wrote: On Fri, Sep 12, 2014 at 05:01:57PM +0300, ville.syrj...@linux.intel.com wrote: From: Ville Syrjälä ville.syrj...@linux.intel.com Bspec says we shouldn't enable IPS on BDW when the pipe pixel rate exceeds 95% of the core