Re: [Intel-gfx] [PATCH v2] drm/i915: Don't touch fence->error when resetting an innocent request

2017-07-21 Thread Joonas Lahtinen
On to, 2017-07-20 at 14:48 +0100, Chris Wilson wrote: > If the request has been completed before the reset took effect, we don't > need to mark it up as being a victim. Touching fence->error after the > fence has been signaled is detected by dma_fence_set_error() and > triggers a BUG: > > [  

Re: [Intel-gfx] [PATCH v2] drm/i915: Don't touch fence->error when resetting an innocent request

2017-07-20 Thread Daniel Vetter
On Thu, Jul 20, 2017 at 02:48:19PM +0100, Chris Wilson wrote: > If the request has been completed before the reset took effect, we don't > need to mark it up as being a victim. Touching fence->error after the > fence has been signaled is detected by dma_fence_set_error() and > triggers a BUG: > >

[Intel-gfx] [PATCH v2] drm/i915: Don't touch fence->error when resetting an innocent request

2017-07-20 Thread Chris Wilson
If the request has been completed before the reset took effect, we don't need to mark it up as being a victim. Touching fence->error after the fence has been signaled is detected by dma_fence_set_error() and triggers a BUG: [ 231.743133] kernel BUG at ./include/linux/dma-fence.h:434! [