Re: [Intel-gfx] [PATCH v2] drm/i915: Push irq_shift from gen8_cs_irq_handler() to caller

2018-03-09 Thread Chris Wilson
Quoting Chris Wilson (2018-03-09 01:08:08) > Originally we were inlining gen8_cs_irq_handler() and so expected the > compiler to constant-fold away the irq_shift (so we had hardcoded it as > opposed to use engine->irq_shift). However, we dropped the inline given > the proliferation of

[Intel-gfx] [PATCH v2] drm/i915: Push irq_shift from gen8_cs_irq_handler() to caller

2018-03-08 Thread Chris Wilson
Originally we were inlining gen8_cs_irq_handler() and so expected the compiler to constant-fold away the irq_shift (so we had hardcoded it as opposed to use engine->irq_shift). However, we dropped the inline given the proliferation of gen8_cs_irq_handler()s. If we pull the shifting of the iir into