Re: [Intel-gfx] [PATCH v2] drm/i915: Rework workaround init functions for BDW and CHV

2014-09-02 Thread Chris Wilson
On Tue, Sep 02, 2014 at 10:45:45AM +0100, Damien Lespiau wrote: > On Tue, Sep 02, 2014 at 10:14:17AM +0100, Arun Siluvery wrote: > > This rework is based on suggestion from Chris. > > Now w/a are organized in an array and all of them are emitted in > > single fn instead of sending them individually

Re: [Intel-gfx] [PATCH v2] drm/i915: Rework workaround init functions for BDW and CHV

2014-09-02 Thread Damien Lespiau
On Tue, Sep 02, 2014 at 10:45:45AM +0100, Damien Lespiau wrote: > There's one case when this won't work, when several WAs for a single > 'normal' register are defined. The read done here means only the last of > those W/As will end up being applied (because the last LRI to that > register will be t

Re: [Intel-gfx] [PATCH v2] drm/i915: Rework workaround init functions for BDW and CHV

2014-09-02 Thread Damien Lespiau
On Tue, Sep 02, 2014 at 10:14:17AM +0100, Arun Siluvery wrote: > This rework is based on suggestion from Chris. > Now w/a are organized in an array and all of them are emitted in > single fn instead of sending them individually. This approach is > clean and new w/a can be added with minimal changes

[Intel-gfx] [PATCH v2] drm/i915: Rework workaround init functions for BDW and CHV

2014-09-02 Thread Arun Siluvery
This rework is based on suggestion from Chris. Now w/a are organized in an array and all of them are emitted in single fn instead of sending them individually. This approach is clean and new w/a can be added with minimal changes. The same array can be used when exporting them to debugfs and the tem