Re: [Intel-gfx] [PATCH v2] drm/i915: State readout and cross-checking for dp_m2_n2

2014-05-19 Thread Vandana Kannan
On May-15-2014 2:48 PM, Vandana Kannan wrote: On May-13-2014 3:10 PM, Vandana Kannan wrote: On May-13-2014 2:28 PM, Daniel Vetter wrote: On Tue, May 13, 2014 at 01:56:04PM +0530, Vandana Kannan wrote: On May-12-2014 3:57 PM, Ville Syrjälä wrote: On Mon, May 05, 2014 at 01:49:31PM +0530,

Re: [Intel-gfx] [PATCH v2] drm/i915: State readout and cross-checking for dp_m2_n2

2014-05-19 Thread Daniel Vetter
On Mon, May 19, 2014 at 05:00:14PM +0530, Vandana Kannan wrote: Please let me know your inputs on this.. Given that making changes to avoid DRRS related checks in pipe_config_compare affects the overall design and future implementations related to RR switching, I think that using a quirk for

Re: [Intel-gfx] [PATCH v2] drm/i915: State readout and cross-checking for dp_m2_n2

2014-05-19 Thread Daniel Vetter
On Mon, May 19, 2014 at 01:45:37PM +0200, Daniel Vetter wrote: On Mon, May 19, 2014 at 05:00:14PM +0530, Vandana Kannan wrote: Please let me know your inputs on this.. Given that making changes to avoid DRRS related checks in pipe_config_compare affects the overall design and future

Re: [Intel-gfx] [PATCH v2] drm/i915: State readout and cross-checking for dp_m2_n2

2014-05-15 Thread Vandana Kannan
On May-13-2014 3:10 PM, Vandana Kannan wrote: On May-13-2014 2:28 PM, Daniel Vetter wrote: On Tue, May 13, 2014 at 01:56:04PM +0530, Vandana Kannan wrote: On May-12-2014 3:57 PM, Ville Syrjälä wrote: On Mon, May 05, 2014 at 01:49:31PM +0530, Vandana Kannan wrote: Adding relevant read out

Re: [Intel-gfx] [PATCH v2] drm/i915: State readout and cross-checking for dp_m2_n2

2014-05-15 Thread Ville Syrjälä
On Thu, May 15, 2014 at 02:48:02PM +0530, Vandana Kannan wrote: On May-13-2014 3:10 PM, Vandana Kannan wrote: On May-13-2014 2:28 PM, Daniel Vetter wrote: On Tue, May 13, 2014 at 01:56:04PM +0530, Vandana Kannan wrote: On May-12-2014 3:57 PM, Ville Syrjälä wrote: On Mon, May 05, 2014 at

Re: [Intel-gfx] [PATCH v2] drm/i915: State readout and cross-checking for dp_m2_n2

2014-05-15 Thread Vandana Kannan
On May-15-2014 3:01 PM, Ville Syrjälä wrote: On Thu, May 15, 2014 at 02:48:02PM +0530, Vandana Kannan wrote: On May-13-2014 3:10 PM, Vandana Kannan wrote: On May-13-2014 2:28 PM, Daniel Vetter wrote: On Tue, May 13, 2014 at 01:56:04PM +0530, Vandana Kannan wrote: On May-12-2014 3:57 PM, Ville

Re: [Intel-gfx] [PATCH v2] drm/i915: State readout and cross-checking for dp_m2_n2

2014-05-13 Thread Vandana Kannan
On May-12-2014 3:57 PM, Ville Syrjälä wrote: On Mon, May 05, 2014 at 01:49:31PM +0530, Vandana Kannan wrote: Adding relevant read out comparison code, in check_crtc_state, for the new member of crtc_config, dp_m2_n2, which was introduced to store link_m_n values for a DP downclock mode (if

Re: [Intel-gfx] [PATCH v2] drm/i915: State readout and cross-checking for dp_m2_n2

2014-05-13 Thread Daniel Vetter
On Tue, May 13, 2014 at 01:56:04PM +0530, Vandana Kannan wrote: On May-12-2014 3:57 PM, Ville Syrjälä wrote: On Mon, May 05, 2014 at 01:49:31PM +0530, Vandana Kannan wrote: Adding relevant read out comparison code, in check_crtc_state, for the new member of crtc_config, dp_m2_n2, which was

Re: [Intel-gfx] [PATCH v2] drm/i915: State readout and cross-checking for dp_m2_n2

2014-05-13 Thread Vandana Kannan
On May-13-2014 2:28 PM, Daniel Vetter wrote: On Tue, May 13, 2014 at 01:56:04PM +0530, Vandana Kannan wrote: On May-12-2014 3:57 PM, Ville Syrjälä wrote: On Mon, May 05, 2014 at 01:49:31PM +0530, Vandana Kannan wrote: Adding relevant read out comparison code, in check_crtc_state, for the new

Re: [Intel-gfx] [PATCH v2] drm/i915: State readout and cross-checking for dp_m2_n2

2014-05-12 Thread Ville Syrjälä
On Mon, May 05, 2014 at 01:49:31PM +0530, Vandana Kannan wrote: Adding relevant read out comparison code, in check_crtc_state, for the new member of crtc_config, dp_m2_n2, which was introduced to store link_m_n values for a DP downclock mode (if available). Suggested by Daniel. v2: Changed

Re: [Intel-gfx] [PATCH v2] drm/i915: State readout and cross-checking for dp_m2_n2

2014-05-12 Thread Daniel Vetter
On Mon, May 12, 2014 at 01:27:25PM +0300, Ville Syrjälä wrote: On Mon, May 05, 2014 at 01:49:31PM +0530, Vandana Kannan wrote: Adding relevant read out comparison code, in check_crtc_state, for the new member of crtc_config, dp_m2_n2, which was introduced to store link_m_n values for a DP

[Intel-gfx] [PATCH v2] drm/i915: State readout and cross-checking for dp_m2_n2

2014-05-05 Thread Vandana Kannan
Adding relevant read out comparison code, in check_crtc_state, for the new member of crtc_config, dp_m2_n2, which was introduced to store link_m_n values for a DP downclock mode (if available). Suggested by Daniel. v2: Changed patch title. Daniel's review comments incorporated. Added relevant