Re: [Intel-gfx] [PATCH v2 06/14] drm/i915: Reorganize plane register writes to make them more atomic

2018-11-08 Thread Ville Syrjälä
On Thu, Nov 08, 2018 at 11:30:07AM -0800, Matt Roper wrote: > On Wed, Nov 07, 2018 at 08:42:55PM +0200, Ville Syrjala wrote: > > From: Ville Syrjälä > > > > Some observations about the plane registers: > > - the control register will self-arm if the plane is not already > > enabled, thus we

Re: [Intel-gfx] [PATCH v2 06/14] drm/i915: Reorganize plane register writes to make them more atomic

2018-11-08 Thread Matt Roper
On Wed, Nov 07, 2018 at 08:42:55PM +0200, Ville Syrjala wrote: > From: Ville Syrjälä > > Some observations about the plane registers: > - the control register will self-arm if the plane is not already > enabled, thus we want to write it as close to (or ideally after) > the surface register >

[Intel-gfx] [PATCH v2 06/14] drm/i915: Reorganize plane register writes to make them more atomic

2018-11-07 Thread Ville Syrjala
From: Ville Syrjälä Some observations about the plane registers: - the control register will self-arm if the plane is not already enabled, thus we want to write it as close to (or ideally after) the surface register - tileoff/linoff/offset/aux_offset are self-arming as well so we want them