Re: [Intel-gfx] [PATCH v2 08/13] drm/i915: Clean up skl+ vs. icl+ watermark computation

2018-11-21 Thread Matt Roper
On Wed, Nov 21, 2018 at 09:05:33PM +0200, Ville Syrjälä wrote: > On Tue, Nov 20, 2018 at 02:44:34PM -0800, Matt Roper wrote: > > On Wed, Nov 14, 2018 at 11:07:24PM +0200, Ville Syrjala wrote: > > > From: Ville Syrjälä ...snip... > > > +static int icl_build_plane_wm(struct skl_ddb_allocation *ddb,

Re: [Intel-gfx] [PATCH v2 08/13] drm/i915: Clean up skl+ vs. icl+ watermark computation

2018-11-21 Thread Ville Syrjälä
On Tue, Nov 20, 2018 at 02:44:34PM -0800, Matt Roper wrote: > On Wed, Nov 14, 2018 at 11:07:24PM +0200, Ville Syrjala wrote: > > From: Ville Syrjälä > > > > Make a cleaner split between the skl+ and icl+ ways of computing > > watermarks. This way skl_build_pipe_wm() doesn't have to know any > >

Re: [Intel-gfx] [PATCH v2 08/13] drm/i915: Clean up skl+ vs. icl+ watermark computation

2018-11-20 Thread Matt Roper
On Wed, Nov 14, 2018 at 11:07:24PM +0200, Ville Syrjala wrote: > From: Ville Syrjälä > > Make a cleaner split between the skl+ and icl+ ways of computing > watermarks. This way skl_build_pipe_wm() doesn't have to know any > of the gritty details of icl+ master/slave planes. > > We can also

[Intel-gfx] [PATCH v2 08/13] drm/i915: Clean up skl+ vs. icl+ watermark computation

2018-11-14 Thread Ville Syrjala
From: Ville Syrjälä Make a cleaner split between the skl+ and icl+ ways of computing watermarks. This way skl_build_pipe_wm() doesn't have to know any of the gritty details of icl+ master/slave planes. We can also simplify a bunch of the lower level code by pulling the plane visibility checks a