Re: [Intel-gfx] [PATCH v2 1/1] drm/i915: Suspend GuC prior to GPU Reset during GEM suspend

2017-04-06 Thread Chris Wilson
On Wed, Apr 05, 2017 at 09:38:49AM -0700, Daniele Ceraolo Spurio wrote: > > > On 05/04/17 05:24, Chris Wilson wrote: > >On Wed, Apr 05, 2017 at 03:51:50PM +0530, Sagar Arun Kamble wrote: > >>i915 is currently doing Full GPU reset at the end of suspend followed by > >>GuC suspend. This reset

Re: [Intel-gfx] [PATCH v2 1/1] drm/i915: Suspend GuC prior to GPU Reset during GEM suspend

2017-04-05 Thread Daniele Ceraolo Spurio
On 05/04/17 05:24, Chris Wilson wrote: On Wed, Apr 05, 2017 at 03:51:50PM +0530, Sagar Arun Kamble wrote: i915 is currently doing Full GPU reset at the end of suspend followed by GuC suspend. This reset bypasses the GuC. We need to tell the GuC to suspend before we do a direct

Re: [Intel-gfx] [PATCH v2 1/1] drm/i915: Suspend GuC prior to GPU Reset during GEM suspend

2017-04-05 Thread David Weinehall
On 2017-04-05 18:46, Kamble, Sagar A wrote: On 4/5/2017 6:32 PM, David Weinehall wrote: On 2017-04-05 15:54, Joonas Lahtinen wrote: On ke, 2017-04-05 at 15:51 +0530, Sagar Arun Kamble wrote: i915 is currently doing Full GPU reset at the end of suspend followed by GuC suspend. This reset

Re: [Intel-gfx] [PATCH v2 1/1] drm/i915: Suspend GuC prior to GPU Reset during GEM suspend

2017-04-05 Thread Kamble, Sagar A
On 4/5/2017 6:32 PM, David Weinehall wrote: On 2017-04-05 15:54, Joonas Lahtinen wrote: On ke, 2017-04-05 at 15:51 +0530, Sagar Arun Kamble wrote: i915 is currently doing Full GPU reset at the end of suspend followed by GuC suspend. This reset bypasses the GuC. We need to tell the GuC to

Re: [Intel-gfx] [PATCH v2 1/1] drm/i915: Suspend GuC prior to GPU Reset during GEM suspend

2017-04-05 Thread David Weinehall
On 2017-04-05 15:54, Joonas Lahtinen wrote: On ke, 2017-04-05 at 15:51 +0530, Sagar Arun Kamble wrote: i915 is currently doing Full GPU reset at the end of suspend followed by GuC suspend. This reset bypasses the GuC. We need to tell the GuC to suspend before we do a direct intel_gpu_reset,

Re: [Intel-gfx] [PATCH v2 1/1] drm/i915: Suspend GuC prior to GPU Reset during GEM suspend

2017-04-05 Thread Chris Wilson
On Wed, Apr 05, 2017 at 03:54:27PM +0300, Joonas Lahtinen wrote: > On ke, 2017-04-05 at 15:51 +0530, Sagar Arun Kamble wrote: > > i915 is currently doing Full GPU reset at the end of suspend followed by > > GuC suspend. This reset bypasses the GuC. We need to tell the GuC to > > suspend before we

Re: [Intel-gfx] [PATCH v2 1/1] drm/i915: Suspend GuC prior to GPU Reset during GEM suspend

2017-04-05 Thread Joonas Lahtinen
On ke, 2017-04-05 at 15:51 +0530, Sagar Arun Kamble wrote: > i915 is currently doing Full GPU reset at the end of suspend followed by > GuC suspend. This reset bypasses the GuC. We need to tell the GuC to > suspend before we do a direct intel_gpu_reset, Otherwise the gpu state will > no longer

Re: [Intel-gfx] [PATCH v2 1/1] drm/i915: Suspend GuC prior to GPU Reset during GEM suspend

2017-04-05 Thread Chris Wilson
On Wed, Apr 05, 2017 at 03:51:50PM +0530, Sagar Arun Kamble wrote: > i915 is currently doing Full GPU reset at the end of suspend followed by > GuC suspend. This reset bypasses the GuC. We need to tell the GuC to > suspend before we do a direct intel_gpu_reset, Otherwise the gpu state will > no

[Intel-gfx] [PATCH v2 1/1] drm/i915: Suspend GuC prior to GPU Reset during GEM suspend

2017-04-05 Thread Sagar Arun Kamble
i915 is currently doing Full GPU reset at the end of suspend followed by GuC suspend. This reset bypasses the GuC. We need to tell the GuC to suspend before we do a direct intel_gpu_reset, Otherwise the gpu state will no longer match the GuC's expectations and its suspend will not be successful.