Re: [Intel-gfx] [PATCH v2 1/3] drm/i915: Skip register reads in i915_get_crtc_scanoutpos()

2013-09-26 Thread Mario Kleiner
On 25.09.13 10:14, Ville Syrjälä wrote: On Wed, Sep 25, 2013 at 04:35:56AM +0200, Mario Kleiner wrote: On 23.09.13 13:48, ville.syrj...@linux.intel.com wrote: From: Ville Syrjälä We have all the information we need in the mode structure, so going and reading it from the hardware is pointless,

Re: [Intel-gfx] [PATCH v2 1/3] drm/i915: Skip register reads in i915_get_crtc_scanoutpos()

2013-09-25 Thread Ville Syrjälä
On Wed, Sep 25, 2013 at 04:35:56AM +0200, Mario Kleiner wrote: > On 23.09.13 13:48, ville.syrj...@linux.intel.com wrote: > > From: Ville Syrjälä > > > > We have all the information we need in the mode structure, so going and > > reading it from the hardware is pointless, and slower. > > > > We nev

Re: [Intel-gfx] [PATCH v2 1/3] drm/i915: Skip register reads in i915_get_crtc_scanoutpos()

2013-09-25 Thread Daniel Vetter
On Wed, Sep 25, 2013 at 6:45 AM, Mario Kleiner wrote: > >> Mario, can you please take a look at these patches and ack them? I'd like >> to slurp them in for -next. > > > Done in the other e-mails, with some comments. However, i'd like to test > these a bit and it might take a week or two before i

Re: [Intel-gfx] [PATCH v2 1/3] drm/i915: Skip register reads in i915_get_crtc_scanoutpos()

2013-09-24 Thread Mario Kleiner
On 23.09.13 13:48, ville.syrj...@linux.intel.com wrote: From: Ville Syrjälä We have all the information we need in the mode structure, so going and reading it from the hardware is pointless, and slower. We never populated ->get_vblank_timestamp() in the UMS case, and as that is the only way we

Re: [Intel-gfx] [PATCH v2 1/3] drm/i915: Skip register reads in i915_get_crtc_scanoutpos()

2013-09-24 Thread Mario Kleiner
On 24.09.13 11:11, Daniel Vetter wrote: ... Hooray, this rips out the racy pipe_to_cpu_transcoder deref, so I'm all in favour \o/ Of course I still have that ugly itme on my todo about "fix the locking for kms vblank stuff" ;-) See the other e-mail i sent. Maybe pushing the time read into th

Re: [Intel-gfx] [PATCH v2 1/3] drm/i915: Skip register reads in i915_get_crtc_scanoutpos()

2013-09-24 Thread Daniel Vetter
On Mon, Sep 23, 2013 at 02:48:50PM +0300, ville.syrj...@linux.intel.com wrote: > From: Ville Syrjälä > > We have all the information we need in the mode structure, so going and > reading it from the hardware is pointless, and slower. > > We never populated ->get_vblank_timestamp() in the UMS cas

[Intel-gfx] [PATCH v2 1/3] drm/i915: Skip register reads in i915_get_crtc_scanoutpos()

2013-09-23 Thread ville . syrjala
From: Ville Syrjälä We have all the information we need in the mode structure, so going and reading it from the hardware is pointless, and slower. We never populated ->get_vblank_timestamp() in the UMS case, and as that is the only way we'd ever call ->get_scanout_position(), we can completely i