Re: [Intel-gfx] [PATCH v2 1/5] drm/i915: Only disable execlist preemption for the duration of the request

2017-01-23 Thread Mika Kuoppala
Chris Wilson writes: > We need to prevent resubmission of the context immediately following an > initial resubmit (which does a lite-restore preemption). Currently we do > this by disabling all submission whilst the context is still active, but > we can improve this by

Re: [Intel-gfx] [PATCH v2 1/5] drm/i915: Only disable execlist preemption for the duration of the request

2017-01-23 Thread Chris Wilson
On Mon, Jan 23, 2017 at 02:33:20PM +0200, Mika Kuoppala wrote: > Chris Wilson writes: > > > On Mon, Jan 23, 2017 at 12:14:25PM +, Chris Wilson wrote: > >> @@ -558,7 +558,8 @@ static bool execlists_elsp_ready(struct > >> intel_engine_cs *engine) > >>int port; >

Re: [Intel-gfx] [PATCH v2 1/5] drm/i915: Only disable execlist preemption for the duration of the request

2017-01-23 Thread Mika Kuoppala
Chris Wilson writes: > On Mon, Jan 23, 2017 at 12:14:25PM +, Chris Wilson wrote: >> @@ -558,7 +558,8 @@ static bool execlists_elsp_ready(struct intel_engine_cs >> *engine) >> int port; >> >> port = 1; /* wait for a free slot */ >> -if

Re: [Intel-gfx] [PATCH v2 1/5] drm/i915: Only disable execlist preemption for the duration of the request

2017-01-23 Thread Chris Wilson
On Mon, Jan 23, 2017 at 12:14:25PM +, Chris Wilson wrote: > @@ -558,7 +558,8 @@ static bool execlists_elsp_ready(struct intel_engine_cs > *engine) > int port; > > port = 1; /* wait for a free slot */ > - if (engine->disable_lite_restore_wa || engine->preempt_wa) > + if

[Intel-gfx] [PATCH v2 1/5] drm/i915: Only disable execlist preemption for the duration of the request

2017-01-23 Thread Chris Wilson
We need to prevent resubmission of the context immediately following an initial resubmit (which does a lite-restore preemption). Currently we do this by disabling all submission whilst the context is still active, but we can improve this by limiting the restriction to only until we receive