Re: [Intel-gfx] [PATCH v2 1/8] drm/i915: Fix unsigned overflow when calculating total data rate

2018-10-19 Thread Maarten Lankhorst
Op 19-10-18 om 15:06 schreef Chris Wilson: > Quoting Maarten Lankhorst (2018-10-19 14:03:47) >> Op 18-10-18 om 17:11 schreef Ville Syrjälä: >>> On Thu, Oct 18, 2018 at 01:51:27PM +0200, Maarten Lankhorst wrote: @@ -4402,8 +4401,7 @@ skl_allocate_pipe_ddb(struct intel_crtc_state *cstate,

Re: [Intel-gfx] [PATCH v2 1/8] drm/i915: Fix unsigned overflow when calculating total data rate

2018-10-19 Thread Chris Wilson
Quoting Maarten Lankhorst (2018-10-19 14:03:47) > Op 18-10-18 om 17:11 schreef Ville Syrjälä: > > On Thu, Oct 18, 2018 at 01:51:27PM +0200, Maarten Lankhorst wrote: > >> @@ -4402,8 +4401,7 @@ skl_allocate_pipe_ddb(struct intel_crtc_state > >> *cstate, > >> * result is < available as

Re: [Intel-gfx] [PATCH v2 1/8] drm/i915: Fix unsigned overflow when calculating total data rate

2018-10-19 Thread Maarten Lankhorst
Op 18-10-18 om 17:11 schreef Ville Syrjälä: > On Thu, Oct 18, 2018 at 01:51:27PM +0200, Maarten Lankhorst wrote: >> On gen11, we can definitely smash the 32-bits barrier with just a >> when we enable all planes in the next patch. >> >> Signed-off-by: Maarten Lankhorst >> --- >>

Re: [Intel-gfx] [PATCH v2 1/8] drm/i915: Fix unsigned overflow when calculating total data rate

2018-10-19 Thread Maarten Lankhorst
Op 18-10-18 om 16:53 schreef Ville Syrjälä: > On Thu, Oct 18, 2018 at 01:51:27PM +0200, Maarten Lankhorst wrote: >> On gen11, we can definitely smash the 32-bits barrier with just a >> when we enable all planes in the next patch. >> >> Signed-off-by: Maarten Lankhorst > I guess the per-plane data

Re: [Intel-gfx] [PATCH v2 1/8] drm/i915: Fix unsigned overflow when calculating total data rate

2018-10-18 Thread Ville Syrjälä
On Thu, Oct 18, 2018 at 01:51:27PM +0200, Maarten Lankhorst wrote: > On gen11, we can definitely smash the 32-bits barrier with just a > when we enable all planes in the next patch. > > Signed-off-by: Maarten Lankhorst > --- > drivers/gpu/drm/i915/intel_pm.c | 47

Re: [Intel-gfx] [PATCH v2 1/8] drm/i915: Fix unsigned overflow when calculating total data rate

2018-10-18 Thread Ville Syrjälä
On Thu, Oct 18, 2018 at 01:51:27PM +0200, Maarten Lankhorst wrote: > On gen11, we can definitely smash the 32-bits barrier with just a > when we enable all planes in the next patch. > > Signed-off-by: Maarten Lankhorst I guess the per-plane data rate is still <32bit (because it doesn't account

[Intel-gfx] [PATCH v2 1/8] drm/i915: Fix unsigned overflow when calculating total data rate

2018-10-18 Thread Maarten Lankhorst
On gen11, we can definitely smash the 32-bits barrier with just a when we enable all planes in the next patch. Signed-off-by: Maarten Lankhorst --- drivers/gpu/drm/i915/intel_pm.c | 47 +++-- 1 file changed, 22 insertions(+), 25 deletions(-) diff --git