Re: [Intel-gfx] [PATCH v2 2/3] drm/i915: Move the .global_resources() hook call into modeset_update_crtc_power_domains()

2014-11-10 Thread Jesse Barnes
On Thu, 6 Nov 2014 14:10:49 +0100 Daniel Vetter dan...@ffwll.ch wrote: On Thu, Nov 06, 2014 at 02:49:12PM +0200, ville.syrj...@linux.intel.com wrote: From: Ville Syrjälä ville.syrj...@linux.intel.com We may need to access various hardware bits in the .global_resources() hook, so move

Re: [Intel-gfx] [PATCH v2 2/3] drm/i915: Move the .global_resources() hook call into modeset_update_crtc_power_domains()

2014-11-10 Thread Ville Syrjälä
On Mon, Nov 10, 2014 at 09:14:11AM -0800, Jesse Barnes wrote: On Thu, 6 Nov 2014 14:10:49 +0100 Daniel Vetter dan...@ffwll.ch wrote: On Thu, Nov 06, 2014 at 02:49:12PM +0200, ville.syrj...@linux.intel.com wrote: From: Ville Syrjälä ville.syrj...@linux.intel.com We may need to

Re: [Intel-gfx] [PATCH v2 2/3] drm/i915: Move the .global_resources() hook call into modeset_update_crtc_power_domains()

2014-11-10 Thread Jesse Barnes
On Mon, 10 Nov 2014 19:24:37 +0200 Ville Syrjälä ville.syrj...@linux.intel.com wrote: On Mon, Nov 10, 2014 at 09:14:11AM -0800, Jesse Barnes wrote: On Thu, 6 Nov 2014 14:10:49 +0100 Daniel Vetter dan...@ffwll.ch wrote: On Thu, Nov 06, 2014 at 02:49:12PM +0200,

[Intel-gfx] [PATCH v2 2/3] drm/i915: Move the .global_resources() hook call into modeset_update_crtc_power_domains()

2014-11-06 Thread ville . syrjala
From: Ville Syrjälä ville.syrj...@linux.intel.com We may need to access various hardware bits in the .global_resources() hook, so move the call to occur after enabling all the newly required power wells, but before disabling all the now unneeded wells. This should guarantee that we have all the

Re: [Intel-gfx] [PATCH v2 2/3] drm/i915: Move the .global_resources() hook call into modeset_update_crtc_power_domains()

2014-11-06 Thread Daniel Vetter
On Thu, Nov 06, 2014 at 02:49:12PM +0200, ville.syrj...@linux.intel.com wrote: From: Ville Syrjälä ville.syrj...@linux.intel.com We may need to access various hardware bits in the .global_resources() hook, so move the call to occur after enabling all the newly required power wells, but