Re: [Intel-gfx] [PATCH v2 2/6] drm/i915/psr: Always wait for idle state when disabling PSR

2018-10-23 Thread Dhinakaran Pandiyan
On Fri, 2018-10-19 at 23:46 +, Souza, Jose wrote: > On Fri, 2018-10-19 at 13:42 -0700, Dhinakaran Pandiyan wrote: > > On Wednesday, October 10, 2018 5:41:20 PM PDT José Roberto de Souza > > wrote: > > > It should always wait for idle state when disabling PSR because "It" is ambiguous here.

Re: [Intel-gfx] [PATCH v2 2/6] drm/i915/psr: Always wait for idle state when disabling PSR

2018-10-19 Thread Souza, Jose
On Fri, 2018-10-19 at 13:42 -0700, Dhinakaran Pandiyan wrote: > On Wednesday, October 10, 2018 5:41:20 PM PDT José Roberto de Souza > wrote: > > It should always wait for idle state when disabling PSR because PSR > > could be inactive due a call to intel_psr_exit() and while PSR is > > still being

Re: [Intel-gfx] [PATCH v2 2/6] drm/i915/psr: Always wait for idle state when disabling PSR

2018-10-19 Thread Dhinakaran Pandiyan
On Fri, 2018-10-19 at 13:42 -0700, Dhinakaran Pandiyan wrote: > On Wednesday, October 10, 2018 5:41:20 PM PDT José Roberto de Souza > wrote: > > It should always wait for idle state when disabling PSR because PSR > > could be inactive due a call to intel_psr_exit() and while PSR is > > still being

Re: [Intel-gfx] [PATCH v2 2/6] drm/i915/psr: Always wait for idle state when disabling PSR

2018-10-19 Thread Dhinakaran Pandiyan
On Wednesday, October 10, 2018 5:41:20 PM PDT José Roberto de Souza wrote: > It should always wait for idle state when disabling PSR because PSR > could be inactive due a call to intel_psr_exit() and while PSR is > still being disabled asynchronously userspace could change the > modeset causing a

[Intel-gfx] [PATCH v2 2/6] drm/i915/psr: Always wait for idle state when disabling PSR

2018-10-10 Thread José Roberto de Souza
It should always wait for idle state when disabling PSR because PSR could be inactive due a call to intel_psr_exit() and while PSR is still being disabled asynchronously userspace could change the modeset causing a call to psr_disable() that will not wait for PSR idle and then PSR will be enabled