Re: [Intel-gfx] [PATCH v2 8/8] drm/i915: Constify states passed to enable/disable/etc. encoder hooks

2017-08-17 Thread Rodrigo Vivi
On Fri, May 19, 2017 at 04:17:25PM +0300, ville.syrj...@linux.intel.com wrote: > From: Ville Syrjälä > > The enable/disable/etc. encoder hooks aren't supposed to alter the > state(s), so pass them as const. Unfortunately C lacks any kind of deep > const thingy, so this can't catch all abuses. But

[Intel-gfx] [PATCH v2 8/8] drm/i915: Constify states passed to enable/disable/etc. encoder hooks

2017-05-19 Thread ville . syrjala
From: Ville Syrjälä The enable/disable/etc. encoder hooks aren't supposed to alter the state(s), so pass them as const. Unfortunately C lacks any kind of deep const thingy, so this can't catch all abuses. But at least it acts as a hint to the reader telling them not to mess about with the state(s