Re: [Intel-gfx] [PATCH v3] drm/i915: Do not use ggtt_view with (aliasing) PPGTT

2015-03-18 Thread Daniel Vetter
On Tue, Mar 17, 2015 at 02:19:18PM +, Tvrtko Ursulin wrote: > > Hi, > > On 03/16/2015 12:11 PM, Joonas Lahtinen wrote: > >GGTT views are only applicable when dealing with GGTT. Change the code to > >reject ggtt_view where it should not be used and require it when it should > >be. > > > >v2: >

Re: [Intel-gfx] [PATCH v3] drm/i915: Do not use ggtt_view with (aliasing) PPGTT

2015-03-17 Thread Tvrtko Ursulin
Hi, On 03/16/2015 12:11 PM, Joonas Lahtinen wrote: GGTT views are only applicable when dealing with GGTT. Change the code to reject ggtt_view where it should not be used and require it when it should be. v2: - Dropped _ppgtt_ infixes, allow both types to be passed - Disregard other but normal

Re: [Intel-gfx] [PATCH v3] drm/i915: Do not use ggtt_view with (aliasing) PPGTT

2015-03-16 Thread Lahtinen, Joonas
On ti, 2015-03-17 at 07:31 +0200, Joonas Lahtinen wrote: > On ma, 2015-03-16 at 18:50 +0100, Daniel Vetter wrote: > > On Mon, Mar 16, 2015 at 02:11:13PM +0200, Joonas Lahtinen wrote: > > [snip] > > > int i915_vma_bind(struct i915_vma *vma, enum i915_cache_level > > > cache_level, > > >

Re: [Intel-gfx] [PATCH v3] drm/i915: Do not use ggtt_view with (aliasing) PPGTT

2015-03-16 Thread Joonas Lahtinen
On ma, 2015-03-16 at 18:50 +0100, Daniel Vetter wrote: > On Mon, Mar 16, 2015 at 02:11:13PM +0200, Joonas Lahtinen wrote: > [snip] > > int i915_vma_bind(struct i915_vma *vma, enum i915_cache_level cache_level, > > u32 flags); > > @@ -2800,60 +2796,48 @@ struct dma_buf *i915_gem_prim

Re: [Intel-gfx] [PATCH v3] drm/i915: Do not use ggtt_view with (aliasing) PPGTT

2015-03-16 Thread Daniel Vetter
On Mon, Mar 16, 2015 at 02:11:13PM +0200, Joonas Lahtinen wrote: > GGTT views are only applicable when dealing with GGTT. Change the code to > reject ggtt_view where it should not be used and require it when it should > be. > > v2: > - Dropped _ppgtt_ infixes, allow both types to be passed > - Dis

Re: [Intel-gfx] [PATCH v3] drm/i915: Do not use ggtt_view with (aliasing) PPGTT

2015-03-16 Thread Tvrtko Ursulin
On 03/16/2015 02:48 PM, Joonas Lahtinen wrote: Hi, Regression testing completed without problems for BYT, HSW and BDW already. On ma, 2015-03-16 at 13:26 +, Tvrtko Ursulin wrote: Hi, On 03/16/2015 12:11 PM, Joonas Lahtinen wrote: GGTT views are only applicable when dealing with GGTT. Ch

Re: [Intel-gfx] [PATCH v3] drm/i915: Do not use ggtt_view with (aliasing) PPGTT

2015-03-16 Thread shuang . he
Tested-By: PRC QA PRTS (Patch Regression Test System Contact: shuang...@intel.com) Task id: 5957 -Summary- Platform Delta drm-intel-nightly Series Applied PNV 275/275

Re: [Intel-gfx] [PATCH v3] drm/i915: Do not use ggtt_view with (aliasing) PPGTT

2015-03-16 Thread Joonas Lahtinen
Hi, Regression testing completed without problems for BYT, HSW and BDW already. On ma, 2015-03-16 at 13:26 +, Tvrtko Ursulin wrote: > Hi, > > On 03/16/2015 12:11 PM, Joonas Lahtinen wrote: > > GGTT views are only applicable when dealing with GGTT. Change the code to > > reject ggtt_view wher

Re: [Intel-gfx] [PATCH v3] drm/i915: Do not use ggtt_view with (aliasing) PPGTT

2015-03-16 Thread Tvrtko Ursulin
Hi, On 03/16/2015 12:11 PM, Joonas Lahtinen wrote: GGTT views are only applicable when dealing with GGTT. Change the code to reject ggtt_view where it should not be used and require it when it should be. v2: - Dropped _ppgtt_ infixes, allow both types to be passed - Disregard other but normal

[Intel-gfx] [PATCH v3] drm/i915: Do not use ggtt_view with (aliasing) PPGTT

2015-03-16 Thread Joonas Lahtinen
GGTT views are only applicable when dealing with GGTT. Change the code to reject ggtt_view where it should not be used and require it when it should be. v2: - Dropped _ppgtt_ infixes, allow both types to be passed - Disregard other but normal views when no view is specified - More checks that vali