Re: [Intel-gfx] [PATCH v3 02/10] drm/i915: Move legacy kernel context pinning to intel_ringbuffer.c

2016-05-26 Thread Chris Wilson
On Thu, May 26, 2016 at 03:04:11PM +0300, Mika Kuoppala wrote: > > + if (ce->state) { > > + i915_gem_context_reference(kctx); > > + > > + /* We may need to do things with the shrinker which > > +* require us to immediately switch back to the default > > +

Re: [Intel-gfx] [PATCH v3 02/10] drm/i915: Move legacy kernel context pinning to intel_ringbuffer.c

2016-05-26 Thread Mika Kuoppala
Chris Wilson writes: > [ text/plain ] > This is so that we have symmetry with intel_lrc.c and avoid a source of > if (i915.enable_execlists) layering violation within i915_gem_context.c - > that is we move the specific handling of the dev_priv->kernel_context > for

[Intel-gfx] [PATCH v3 02/10] drm/i915: Move legacy kernel context pinning to intel_ringbuffer.c

2016-05-26 Thread Chris Wilson
This is so that we have symmetry with intel_lrc.c and avoid a source of if (i915.enable_execlists) layering violation within i915_gem_context.c - that is we move the specific handling of the dev_priv->kernel_context for legacy submission into the legacy submission code. This depends upon the