Re: [Intel-gfx] [PATCH v3 1/1] vfio: remove VFIO_GROUP_NOTIFY_SET_KVM

2023-01-06 Thread Jason Gunthorpe
On Thu, Jan 05, 2023 at 08:03:32PM -0500, Matthew Rosato wrote: > On 1/5/23 7:32 PM, Jason Gunthorpe wrote: > > On Thu, Jan 05, 2023 at 07:16:37PM -0500, Matthew Rosato wrote: > > > >> Yeah, this is also what I was thinking, replace the direct > >> kvm_put_kvm calls with, say,

Re: [Intel-gfx] [PATCH v3 1/1] vfio: remove VFIO_GROUP_NOTIFY_SET_KVM

2023-01-05 Thread Matthew Rosato
On 1/5/23 6:34 PM, Jason Gunthorpe wrote: > On Thu, Jan 05, 2023 at 03:09:30PM -0700, Alex Williamson wrote: >> On Thu, 19 May 2022 14:33:11 -0400 >> Matthew Rosato wrote: >> >>> Rather than relying on a notifier for associating the KVM with >>> the group, let's assume that the association has

Re: [Intel-gfx] [PATCH v3 1/1] vfio: remove VFIO_GROUP_NOTIFY_SET_KVM

2023-01-05 Thread Matthew Rosato
On 1/5/23 7:32 PM, Jason Gunthorpe wrote: > On Thu, Jan 05, 2023 at 07:16:37PM -0500, Matthew Rosato wrote: > >> Yeah, this is also what I was thinking, replace the direct >> kvm_put_kvm calls with, say, schedule_delayed_work in each driver, >> where the delayed task just does the kvm_put_kvm

Re: [Intel-gfx] [PATCH v3 1/1] vfio: remove VFIO_GROUP_NOTIFY_SET_KVM

2023-01-05 Thread Jason Gunthorpe
On Thu, Jan 05, 2023 at 07:16:37PM -0500, Matthew Rosato wrote: > Yeah, this is also what I was thinking, replace the direct > kvm_put_kvm calls with, say, schedule_delayed_work in each driver, > where the delayed task just does the kvm_put_kvm (along with a brief > comment explaining why we

Re: [Intel-gfx] [PATCH v3 1/1] vfio: remove VFIO_GROUP_NOTIFY_SET_KVM

2023-01-05 Thread Jason Gunthorpe
On Thu, Jan 05, 2023 at 03:09:30PM -0700, Alex Williamson wrote: > On Thu, 19 May 2022 14:33:11 -0400 > Matthew Rosato wrote: > > > Rather than relying on a notifier for associating the KVM with > > the group, let's assume that the association has already been > > made prior to device_open. The

Re: [Intel-gfx] [PATCH v3 1/1] vfio: remove VFIO_GROUP_NOTIFY_SET_KVM

2023-01-05 Thread Alex Williamson
On Thu, 19 May 2022 14:33:11 -0400 Matthew Rosato wrote: > Rather than relying on a notifier for associating the KVM with > the group, let's assume that the association has already been > made prior to device_open. The first time a device is opened > associate the group KVM with the device. >

Re: [Intel-gfx] [PATCH v3 1/1] vfio: remove VFIO_GROUP_NOTIFY_SET_KVM

2022-05-24 Thread Wang, Zhi A
On 5/23/22 4:41 PM, Alex Williamson wrote: > > Hi Zhi & Zhenyu, > > Please review gvt changes below, I'd prefer to get your ack included. > Thanks! > > Alex > > On Thu, 19 May 2022 14:33:11 -0400 > Matthew Rosato wrote: > >> Rather than relying on a notifier for associating the KVM with >>

Re: [Intel-gfx] [PATCH v3 1/1] vfio: remove VFIO_GROUP_NOTIFY_SET_KVM

2022-05-23 Thread Alex Williamson
Hi Zhi & Zhenyu, Please review gvt changes below, I'd prefer to get your ack included. Thanks! Alex On Thu, 19 May 2022 14:33:11 -0400 Matthew Rosato wrote: > Rather than relying on a notifier for associating the KVM with > the group, let's assume that the association has already been >

Re: [Intel-gfx] [PATCH v3 1/1] vfio: remove VFIO_GROUP_NOTIFY_SET_KVM

2022-05-19 Thread Christoph Hellwig
Looks good: Reviewed-by: Christoph Hellwig