[Intel-gfx] [PATCH v3 1/2] drm/i915: remove unnecessary null test

2015-07-21 Thread Sudip Mukherjee
While creating the debugfs file we are setting the inode-i_private to dev. That same dev is passed to these functions as private of struct seq_file via single_open(). Moreover single_open is setting file-private_data-private to dev. So at this point it can never be NULL. This check was added by

Re: [Intel-gfx] [PATCH v3 1/2] drm/i915: remove unnecessary null test

2015-07-21 Thread Daniel Vetter
On Tue, Jul 21, 2015 at 05:36:45PM +0530, Sudip Mukherjee wrote: While creating the debugfs file we are setting the inode-i_private to dev. That same dev is passed to these functions as private of struct seq_file via single_open(). Moreover single_open is setting file-private_data-private to

Re: [Intel-gfx] [PATCH v3 1/2] drm/i915: remove unnecessary null test

2015-07-21 Thread Sudip Mukherjee
On Tue, Jul 21, 2015 at 03:51:40PM +0200, Daniel Vetter wrote: On Tue, Jul 21, 2015 at 05:36:45PM +0530, Sudip Mukherjee wrote: While creating the debugfs file we are setting the inode-i_private to dev. That same dev is passed to these functions as private of struct seq_file via