Re: [Intel-gfx] [PATCH v3 2/2] drm/i915/guc : Decouple logs from submission

2017-09-19 Thread Sujaritha
Sure, I will rename the commit message. Thanks. On 09/19/2017 10:11 AM, Daniele Ceraolo Spurio wrote: Since we're not decoupling just logs, maybe the commit could be renamed to "Decouple ADS and logs from submission" On 19/09/17 09:15, Sujaritha Sundaresan wrote: The Additional Data Struct

Re: [Intel-gfx] [PATCH v3 2/2] drm/i915/guc : Decouple logs from submission

2017-09-19 Thread Daniele Ceraolo Spurio
Since we're not decoupling just logs, maybe the commit could be renamed to "Decouple ADS and logs from submission" On 19/09/17 09:15, Sujaritha Sundaresan wrote: The Additional Data Struct (ADS) contains objects that are required by guc post FW load and are not necessarily submission-only

[Intel-gfx] [PATCH v3 2/2] drm/i915/guc : Decouple logs from submission

2017-09-19 Thread Sujaritha Sundaresan
The Additional Data Struct (ADS) contains objects that are required by guc post FW load and are not necessarily submission-only (although that's our current only use-case). If in the future we load GuC with submission disabled to use some other GuC feature we might still end up requiring something