Re: [Intel-gfx] [PATCH v3 3/3] drm/vgem: use normal cached mmap'ings

2019-07-19 Thread Daniel Vetter
On Tue, Jul 16, 2019 at 05:13:10PM -0700, Rob Clark wrote: > On Tue, Jul 16, 2019 at 4:39 PM Eric Anholt wrote: > > > > Rob Clark writes: > > > > > From: Rob Clark > > > > > > Since there is no real device associated with VGEM, it is impossible to > > > end up with appropriate dev->dma_ops,

Re: [Intel-gfx] [PATCH v3 3/3] drm/vgem: use normal cached mmap'ings

2019-07-16 Thread Rob Clark
On Tue, Jul 16, 2019 at 4:39 PM Eric Anholt wrote: > > Rob Clark writes: > > > From: Rob Clark > > > > Since there is no real device associated with VGEM, it is impossible to > > end up with appropriate dev->dma_ops, meaning that we have no way to > > invalidate the shmem pages allocated by

Re: [Intel-gfx] [PATCH v3 3/3] drm/vgem: use normal cached mmap'ings

2019-07-16 Thread Eric Anholt
Rob Clark writes: > From: Rob Clark > > Since there is no real device associated with VGEM, it is impossible to > end up with appropriate dev->dma_ops, meaning that we have no way to > invalidate the shmem pages allocated by VGEM. So, at least on platforms > without drm_cflush_pages(), we end

[Intel-gfx] [PATCH v3 3/3] drm/vgem: use normal cached mmap'ings

2019-07-16 Thread Rob Clark
From: Rob Clark Since there is no real device associated with VGEM, it is impossible to end up with appropriate dev->dma_ops, meaning that we have no way to invalidate the shmem pages allocated by VGEM. So, at least on platforms without drm_cflush_pages(), we end up with corruption when cache