Re: [Intel-gfx] [PATCH v4] drm/i915: Synchronize active and retire callbacks

2020-04-21 Thread Sultan Alsawaf
On Tue, Apr 21, 2020 at 09:51:37AM +0300, Joonas Lahtinen wrote: > Quoting Sultan Alsawaf (2020-04-20 19:15:14) > > On Mon, Apr 20, 2020 at 11:21:42AM +0300, Joonas Lahtinen wrote: > > > So it seems that the patch got pulled into v5.6 and has been backported > > > to v5.5 but not v5.4. > > > >

Re: [Intel-gfx] [PATCH v4] drm/i915: Synchronize active and retire callbacks

2020-04-21 Thread Joonas Lahtinen
Quoting Sultan Alsawaf (2020-04-20 19:15:14) > On Mon, Apr 20, 2020 at 11:21:42AM +0300, Joonas Lahtinen wrote: > > So it seems that the patch got pulled into v5.6 and has been backported > > to v5.5 but not v5.4. > > You're right, that's my mistake. Did applying the patch to v5.4 fix the issue

Re: [Intel-gfx] [PATCH v4] drm/i915: Synchronize active and retire callbacks

2020-04-20 Thread Sultan Alsawaf
Chris, Could you please look at this in earnest? This is a real bug that crashes my laptop without any kind of provocation. It is undeniably a bug in i915, and I've clearly described it in my patch. If you dont like the patch, I'm open to any suggestions you have for an alternative solution. My

Re: [Intel-gfx] [PATCH v4] drm/i915: Synchronize active and retire callbacks

2020-04-20 Thread Sultan Alsawaf
On Mon, Apr 20, 2020 at 11:21:42AM +0300, Joonas Lahtinen wrote: > So it seems that the patch got pulled into v5.6 and has been backported > to v5.5 but not v5.4. You're right, that's my mistake. > In doing that zeroing of ring->vaddr is removed so the test to do mdelay(1) > and "ring->vaddr =

Re: [Intel-gfx] [PATCH v4] drm/i915: Synchronize active and retire callbacks

2020-04-20 Thread Joonas Lahtinen
Quoting Sultan Alsawaf (2020-04-20 08:24:19) > Chris, > > Could you please look at this in earnest? This is a real bug that crashes my > laptop without any kind of provocation. It is undeniably a bug in i915, and > I've > clearly described it in my patch. If you dont like the patch, I'm open to

Re: [Intel-gfx] [PATCH v4] drm/i915: Synchronize active and retire callbacks

2020-04-14 Thread Sultan Alsawaf
On Tue, Apr 14, 2020 at 09:23:56AM +0100, Chris Wilson wrote: > Quoting Sultan Alsawaf (2020-04-14 07:13:12) > > Chris, > > > > Could you please take a look at this? This really is quite an important fix. > > It's crazy. See a266bf420060 for a patch that should be applied to v5.4 > -Chris What?

Re: [Intel-gfx] [PATCH v4] drm/i915: Synchronize active and retire callbacks

2020-04-14 Thread Chris Wilson
Quoting Sultan Alsawaf (2020-04-14 07:13:12) > Chris, > > Could you please take a look at this? This really is quite an important fix. It's crazy. See a266bf420060 for a patch that should be applied to v5.4 -Chris ___ Intel-gfx mailing list

Re: [Intel-gfx] [PATCH v4] drm/i915: Synchronize active and retire callbacks

2020-04-14 Thread Sultan Alsawaf
Chris, Could you please take a look at this? This really is quite an important fix. Thanks, Sultan ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx