Re: [Intel-gfx] [PATCH v5 00/16] acpi/pwm/i915: Convert pwm-crc and i915 driver's PWM code to use the atomic PWM API

2020-08-02 Thread Hans de Goede
Hi, On 8/2/20 1:25 PM, Andy Shevchenko wrote: On Sat, Aug 01, 2020 at 04:38:16PM +0200, Hans de Goede wrote: On 7/29/20 12:54 PM, Andy Shevchenko wrote: On Fri, Jul 17, 2020 at 03:37:37PM +0200, Hans de Goede wrote: ... One comment to consider, though. There are three channels in that PWM

Re: [Intel-gfx] [PATCH v5 00/16] acpi/pwm/i915: Convert pwm-crc and i915 driver's PWM code to use the atomic PWM API

2020-08-02 Thread Andy Shevchenko
On Sat, Aug 01, 2020 at 04:38:16PM +0200, Hans de Goede wrote: > On 7/29/20 12:54 PM, Andy Shevchenko wrote: > > On Fri, Jul 17, 2020 at 03:37:37PM +0200, Hans de Goede wrote: ... > > One comment to consider, though. There are three channels in that PWM AFAIU. > > One of them is backlight

Re: [Intel-gfx] [PATCH v5 00/16] acpi/pwm/i915: Convert pwm-crc and i915 driver's PWM code to use the atomic PWM API

2020-08-01 Thread Hans de Goede
Hi, On 7/29/20 12:54 PM, Andy Shevchenko wrote: On Fri, Jul 17, 2020 at 03:37:37PM +0200, Hans de Goede wrote: Hi All, Here is v5 of my patch series converting the i915 driver's code for controlling the panel's backlight with an external PWM controller to use the atomic PWM API. See below for

Re: [Intel-gfx] [PATCH v5 00/16] acpi/pwm/i915: Convert pwm-crc and i915 driver's PWM code to use the atomic PWM API

2020-08-01 Thread Hans de Goede
Hi Thierry, On 7/30/20 11:26 AM, Thierry Reding wrote: On Wed, Jul 29, 2020 at 11:32:28AM +0200, Hans de Goede wrote: cHi, On 7/29/20 10:23 AM, Andy Shevchenko wrote: On Mon, Jul 27, 2020 at 09:41:20AM +0200, Thierry Reding wrote: On Fri, Jul 17, 2020 at 03:37:37PM +0200, Hans de Goede

Re: [Intel-gfx] [PATCH v5 00/16] acpi/pwm/i915: Convert pwm-crc and i915 driver's PWM code to use the atomic PWM API

2020-07-30 Thread Thierry Reding
On Wed, Jul 29, 2020 at 11:32:28AM +0200, Hans de Goede wrote: > cHi, > > On 7/29/20 10:23 AM, Andy Shevchenko wrote: > > On Mon, Jul 27, 2020 at 09:41:20AM +0200, Thierry Reding wrote: > > > On Fri, Jul 17, 2020 at 03:37:37PM +0200, Hans de Goede wrote: > > > > > I've applied patches 3 through

Re: [Intel-gfx] [PATCH v5 00/16] acpi/pwm/i915: Convert pwm-crc and i915 driver's PWM code to use the atomic PWM API

2020-07-29 Thread Andy Shevchenko
On Fri, Jul 17, 2020 at 03:37:37PM +0200, Hans de Goede wrote: > Hi All, > > Here is v5 of my patch series converting the i915 driver's code for > controlling the panel's backlight with an external PWM controller to > use the atomic PWM API. See below for the changelog. > > This series consists

Re: [Intel-gfx] [PATCH v5 00/16] acpi/pwm/i915: Convert pwm-crc and i915 driver's PWM code to use the atomic PWM API

2020-07-29 Thread Hans de Goede
cHi, On 7/29/20 10:23 AM, Andy Shevchenko wrote: On Mon, Jul 27, 2020 at 09:41:20AM +0200, Thierry Reding wrote: On Fri, Jul 17, 2020 at 03:37:37PM +0200, Hans de Goede wrote: I've applied patches 3 through 12 to the PWM tree. I thought it was a bit odd that only a handful of these patches

Re: [Intel-gfx] [PATCH v5 00/16] acpi/pwm/i915: Convert pwm-crc and i915 driver's PWM code to use the atomic PWM API

2020-07-29 Thread Andy Shevchenko
On Mon, Jul 27, 2020 at 09:41:20AM +0200, Thierry Reding wrote: > On Fri, Jul 17, 2020 at 03:37:37PM +0200, Hans de Goede wrote: > I've applied patches 3 through 12 to the PWM tree. I thought it was a > bit odd that only a handful of these patches had been reviewed and there > were no Tested-bys,

Re: [Intel-gfx] [PATCH v5 00/16] acpi/pwm/i915: Convert pwm-crc and i915 driver's PWM code to use the atomic PWM API

2020-07-27 Thread Thierry Reding
On Fri, Jul 17, 2020 at 03:37:37PM +0200, Hans de Goede wrote: > Hi All, > > Here is v5 of my patch series converting the i915 driver's code for > controlling the panel's backlight with an external PWM controller to > use the atomic PWM API. See below for the changelog. > > This series consists

[Intel-gfx] [PATCH v5 00/16] acpi/pwm/i915: Convert pwm-crc and i915 driver's PWM code to use the atomic PWM API

2020-07-17 Thread Hans de Goede
Hi All, Here is v5 of my patch series converting the i915 driver's code for controlling the panel's backlight with an external PWM controller to use the atomic PWM API. See below for the changelog. This series consists of 4 parts: 1. acpi_lpss fixes workarounds for Cherry Trail DSTD nastiness