Re: [Intel-gfx] [PATCH v5 01/10] drm/i915/guc: Update GuC ADS size for error capture lists

2022-02-03 Thread Teres Alexis, Alan Previn
So we are coming to an agreement... I will go with the option of ADS calling intel_guc_capture and asking it for the temp buf ptr and size and let ADS do the actual copying. I will have to see how straight forward the copying will be (if u see RFC-rev1 of this series, the ADS does the full

Re: [Intel-gfx] [PATCH v5 01/10] drm/i915/guc: Update GuC ADS size for error capture lists

2022-02-03 Thread Lucas De Marchi
On Thu, Feb 03, 2022 at 12:40:54PM -0800, Teres Alexis, Alan Previn wrote: Apologies, please ignore last reply (wrestling with my VNC). Proper reply: On Thu, 2022-02-03 at 12:39 -0800, Alan Previn Teres Alexis wrote: On Thu, 2022-02-03 at 12:04 -0800, Lucas De Marchi wrote: > On Thu, Feb 03,

Re: [Intel-gfx] [PATCH v5 01/10] drm/i915/guc: Update GuC ADS size for error capture lists

2022-02-03 Thread Teres Alexis, Alan Previn
Apologies, please ignore last reply (wrestling with my VNC). Proper reply: On Thu, 2022-02-03 at 12:39 -0800, Alan Previn Teres Alexis wrote: > > > On Thu, 2022-02-03 at 12:04 -0800, Lucas De Marchi wrote: > > On Thu, Feb 03, 2022 at 11:03:24AM -0800, Matthew Brost wrote: > > > On Wed, Jan 26,

Re: [Intel-gfx] [PATCH v5 01/10] drm/i915/guc: Update GuC ADS size for error capture lists

2022-02-03 Thread Teres Alexis, Alan Previn
I can refactor my code to enforce an owner module to only return the size and an interim buffer pointer (kzalloc, not io mem) and have ADS memcpy from that pointer into the ADS substructure pointer.. But I hope we can make it a rule that its okay for an external owner-module to know and

Re: [Intel-gfx] [PATCH v5 01/10] drm/i915/guc: Update GuC ADS size for error capture lists

2022-02-03 Thread Lucas De Marchi
On Thu, Feb 03, 2022 at 11:03:24AM -0800, Matthew Brost wrote: On Wed, Jan 26, 2022 at 02:46:19PM -0800, Lucas De Marchi wrote: On Wed, Jan 26, 2022 at 02:48:13AM -0800, Alan Previn wrote: > Update GuC ADS size allocation to include space for > the lists of error state capture register

Re: [Intel-gfx] [PATCH v5 01/10] drm/i915/guc: Update GuC ADS size for error capture lists

2022-02-03 Thread Matthew Brost
On Wed, Jan 26, 2022 at 02:46:19PM -0800, Lucas De Marchi wrote: > On Wed, Jan 26, 2022 at 02:48:13AM -0800, Alan Previn wrote: > > Update GuC ADS size allocation to include space for > > the lists of error state capture register descriptors. > > > > Also, populate the lists of registers we want

Re: [Intel-gfx] [PATCH v5 01/10] drm/i915/guc: Update GuC ADS size for error capture lists

2022-01-26 Thread Lucas De Marchi
On Wed, Jan 26, 2022 at 02:48:13AM -0800, Alan Previn wrote: Update GuC ADS size allocation to include space for the lists of error state capture register descriptors. Also, populate the lists of registers we want GuC to report back to Host on engine reset events. This list should include

Re: [Intel-gfx] [PATCH v5 01/10] drm/i915/guc: Update GuC ADS size for error capture lists

2022-01-26 Thread Jani Nikula
On Wed, 26 Jan 2022, Alan Previn wrote: > Update GuC ADS size allocation to include space for > the lists of error state capture register descriptors. > > Also, populate the lists of registers we want GuC to report back to > Host on engine reset events. This list should include global, >

Re: [Intel-gfx] [PATCH v5 01/10] drm/i915/guc: Update GuC ADS size for error capture lists

2022-01-26 Thread Jani Nikula
On Wed, 26 Jan 2022, Alan Previn wrote: > Update GuC ADS size allocation to include space for > the lists of error state capture register descriptors. > > Also, populate the lists of registers we want GuC to report back to > Host on engine reset events. This list should include global, >

[Intel-gfx] [PATCH v5 01/10] drm/i915/guc: Update GuC ADS size for error capture lists

2022-01-26 Thread Alan Previn
Update GuC ADS size allocation to include space for the lists of error state capture register descriptors. Also, populate the lists of registers we want GuC to report back to Host on engine reset events. This list should include global, engine-class and engine-instance registers for every