Re: [Intel-gfx] [PATCH v5 02/10] drm/i915/guc: Add XE_LP registers for GuC error state capture.

2022-01-28 Thread Teres Alexis, Alan Previn
Facepalming myself - yes you're right - that's an easy fix... move the device specific ext-list into the guc_capture_priv structure which is allocated per gt. Thanks Jani. ...alan On Thu, 2022-01-27 at 11:30 +0200, Jani Nikula wrote: > On Wed, 26 Jan 2022, "Teres Alexis, Alan Previn" >

Re: [Intel-gfx] [PATCH v5 02/10] drm/i915/guc: Add XE_LP registers for GuC error state capture.

2022-01-27 Thread Jani Nikula
On Wed, 26 Jan 2022, "Teres Alexis, Alan Previn" wrote: > Thanks Jani for taking the time to review... > > 1. apologies on the const issue, this is my bad, i think it was > one of the comments from earlier rev not sure how i missed it. > Will fix this on next rev. > > 2. I do have a question

Re: [Intel-gfx] [PATCH v5 02/10] drm/i915/guc: Add XE_LP registers for GuC error state capture.

2022-01-26 Thread Teres Alexis, Alan Previn
Thanks Jani for taking the time to review... 1. apologies on the const issue, this is my bad, i think it was one of the comments from earlier rev not sure how i missed it. Will fix this on next rev. 2. I do have a question below on the const for one of specific types of tables. Need your

Re: [Intel-gfx] [PATCH v5 02/10] drm/i915/guc: Add XE_LP registers for GuC error state capture.

2022-01-26 Thread Jani Nikula
On Wed, 26 Jan 2022, Alan Previn wrote: > Add device specific tables and register lists to cover different engines > class types for GuC error state capture for XE_LP products. > > Also, add runtime allocation and freeing of extended register lists > for registers that need steering identifiers

[Intel-gfx] [PATCH v5 02/10] drm/i915/guc: Add XE_LP registers for GuC error state capture.

2022-01-26 Thread Alan Previn
Add device specific tables and register lists to cover different engines class types for GuC error state capture for XE_LP products. Also, add runtime allocation and freeing of extended register lists for registers that need steering identifiers that depend on the detected HW config.