Re: [Intel-gfx] [PATCH v5 06/10] drm/i915/guc: Update GuC's log-buffer-state access for error capture.

2022-02-14 Thread Teres Alexis, Alan Previn
Looks like trying to move the vma up into guc-upper is impacting many other functions in intel_guc_log and intel_guc_log_debugfs. I'll have to take it back (the level of redesign i shall attempt with this series). I'll just move the log_stats back into intel_guc_log and have intel_guc_capture

Re: [Intel-gfx] [PATCH v5 06/10] drm/i915/guc: Update GuC's log-buffer-state access for error capture.

2022-02-14 Thread Teres Alexis, Alan Previn
Matt, just a final confirmation on below > > > > > > > > > > On Fri, 2022-02-04 at 10:19 -0800, Matthew Brost wrote: > > > > > > On Wed, Jan 26, 2022 at 02:48:18AM -0800, Alan Previn wrote: > > > > > > > > > If the object lives at the GuC level, operate on it at the GuC level. > > > > e.g. > >

Re: [Intel-gfx] [PATCH v5 06/10] drm/i915/guc: Update GuC's log-buffer-state access for error capture.

2022-02-08 Thread Teres Alexis, Alan Previn
On Tue, 2022-02-08 at 19:34 -0800, Matthew Brost wrote: > On Tue, Feb 08, 2022 at 02:55:07PM -0800, Teres Alexis, Alan Previn wrote: > > On Tue, 2022-02-08 at 14:18 -0800, Matthew Brost wrote: > > > On Tue, Feb 08, 2022 at 11:38:13AM -0800, Teres Alexis, Alan Previn wrote: > > > > Hi Matt, thank

Re: [Intel-gfx] [PATCH v5 06/10] drm/i915/guc: Update GuC's log-buffer-state access for error capture.

2022-02-08 Thread Matthew Brost
On Tue, Feb 08, 2022 at 07:34:37PM -0800, Matthew Brost wrote: > On Tue, Feb 08, 2022 at 02:55:07PM -0800, Teres Alexis, Alan Previn wrote: > > > > On Tue, 2022-02-08 at 14:18 -0800, Matthew Brost wrote: > > > On Tue, Feb 08, 2022 at 11:38:13AM -0800, Teres Alexis, Alan Previn wrote: > > > > Hi

Re: [Intel-gfx] [PATCH v5 06/10] drm/i915/guc: Update GuC's log-buffer-state access for error capture.

2022-02-08 Thread Matthew Brost
On Tue, Feb 08, 2022 at 02:55:07PM -0800, Teres Alexis, Alan Previn wrote: > > On Tue, 2022-02-08 at 14:18 -0800, Matthew Brost wrote: > > On Tue, Feb 08, 2022 at 11:38:13AM -0800, Teres Alexis, Alan Previn wrote: > > > Hi Matt, thank you for taking the time to review the codes. > > > Answering

Re: [Intel-gfx] [PATCH v5 06/10] drm/i915/guc: Update GuC's log-buffer-state access for error capture.

2022-02-08 Thread Teres Alexis, Alan Previn
On Tue, 2022-02-08 at 14:18 -0800, Matthew Brost wrote: > On Tue, Feb 08, 2022 at 11:38:13AM -0800, Teres Alexis, Alan Previn wrote: > > Hi Matt, thank you for taking the time to review the codes. > > Answering your question inline below. > > > > > > On Fri, 2022-02-04 at 10:19 -0800, Matthew

Re: [Intel-gfx] [PATCH v5 06/10] drm/i915/guc: Update GuC's log-buffer-state access for error capture.

2022-02-08 Thread Matthew Brost
On Tue, Feb 08, 2022 at 11:38:13AM -0800, Teres Alexis, Alan Previn wrote: > Hi Matt, thank you for taking the time to review the codes. > Answering your question inline below. > > > On Fri, 2022-02-04 at 10:19 -0800, Matthew Brost wrote: > > On Wed, Jan 26, 2022 at 02:48:18AM -0800, Alan Previn

Re: [Intel-gfx] [PATCH v5 06/10] drm/i915/guc: Update GuC's log-buffer-state access for error capture.

2022-02-08 Thread Teres Alexis, Alan Previn
Hi Matt, thank you for taking the time to review the codes. Answering your question inline below. On Fri, 2022-02-04 at 10:19 -0800, Matthew Brost wrote: > On Wed, Jan 26, 2022 at 02:48:18AM -0800, Alan Previn wrote: > > GuC log buffer regions for debug-log-events, crash-dumps and > >

Re: [Intel-gfx] [PATCH v5 06/10] drm/i915/guc: Update GuC's log-buffer-state access for error capture.

2022-02-04 Thread Matthew Brost
On Wed, Jan 26, 2022 at 02:48:18AM -0800, Alan Previn wrote: > GuC log buffer regions for debug-log-events, crash-dumps and > error-state-capture are all a single bo allocation that includes > the guc_log_buffer_state structures. > > Since the error-capture region is accessed with high priority

Re: [Intel-gfx] [PATCH v5 06/10] drm/i915/guc: Update GuC's log-buffer-state access for error capture.

2022-01-26 Thread Teres Alexis, Alan Previn
As per the rev 5 CI results between this patch and patch7, i have introduced a lockdep splat bug, i shall fix that in the next rev. ...alan On Wed, 2022-01-26 at 02:48 -0800, Alan Previn wrote: > GuC log buffer regions for debug-log-events, crash-dumps and > error-state-capture are all a single

[Intel-gfx] [PATCH v5 06/10] drm/i915/guc: Update GuC's log-buffer-state access for error capture.

2022-01-26 Thread Alan Previn
GuC log buffer regions for debug-log-events, crash-dumps and error-state-capture are all a single bo allocation that includes the guc_log_buffer_state structures. Since the error-capture region is accessed with high priority at non- deterministic times (as part of gpu coredump) while the