Re: [Intel-gfx] [PATCH v5 30/46] regulator: pwm: retrieve correct voltage

2016-04-12 Thread Boris Brezillon
On Tue, 12 Apr 2016 11:09:38 +0100 Mark Brown wrote: > On Tue, Apr 12, 2016 at 10:37:22AM +0200, Boris Brezillon wrote: > > Mark Brown wrote: > > > On Thu, Apr 07, 2016 at 11:54:31PM +0200, Boris Brezillon wrote: > > > > I'm not sure there's a strong

Re: [Intel-gfx] [PATCH v5 30/46] regulator: pwm: retrieve correct voltage

2016-04-12 Thread Mark Brown
On Tue, Apr 12, 2016 at 10:37:22AM +0200, Boris Brezillon wrote: > Mark Brown wrote: > > On Thu, Apr 07, 2016 at 11:54:31PM +0200, Boris Brezillon wrote: > > I'm not sure there's a strong one, we don't really use the class device > > for anything, but without doing a full

Re: [Intel-gfx] [PATCH v5 30/46] regulator: pwm: retrieve correct voltage

2016-04-12 Thread Boris Brezillon
Hi Mark, On Tue, 12 Apr 2016 05:42:03 +0100 Mark Brown wrote: > On Thu, Apr 07, 2016 at 11:54:31PM +0200, Boris Brezillon wrote: > > > Is there any reason for calling set_machine_constraints() after > > device_register() in regulator_register()? > > I'm not sure there's a

Re: [Intel-gfx] [PATCH v5 30/46] regulator: pwm: retrieve correct voltage

2016-04-11 Thread Mark Brown
On Thu, Apr 07, 2016 at 11:54:31PM +0200, Boris Brezillon wrote: > Is there any reason for calling set_machine_constraints() after > device_register() in regulator_register()? I'm not sure there's a strong one, we don't really use the class device for anything, but without doing a full audit I

Re: [Intel-gfx] [PATCH v5 30/46] regulator: pwm: retrieve correct voltage

2016-04-07 Thread Boris Brezillon
Hi Mark, On Wed, 30 Mar 2016 14:24:10 -0700 Mark Brown wrote: > On Wed, Mar 30, 2016 at 10:03:53PM +0200, Boris Brezillon wrote: > > The continuous PWM voltage regulator is caching the voltage value in > > the ->volt_uV field. While most of the time this value should reflect

Re: [Intel-gfx] [PATCH v5 30/46] regulator: pwm: retrieve correct voltage

2016-03-30 Thread Mark Brown
On Wed, Mar 30, 2016 at 10:03:53PM +0200, Boris Brezillon wrote: > The continuous PWM voltage regulator is caching the voltage value in > the ->volt_uV field. While most of the time this value should reflect the > real voltage, sometime it can be sightly different if the PWM device > rounded the

[Intel-gfx] [PATCH v5 30/46] regulator: pwm: retrieve correct voltage

2016-03-30 Thread Boris Brezillon
The continuous PWM voltage regulator is caching the voltage value in the ->volt_uV field. While most of the time this value should reflect the real voltage, sometime it can be sightly different if the PWM device rounded the set_duty_cycle request. Moreover, this value is not valid until someone