Re: [Intel-gfx] [PATCH v6 03/10] drm/i915: s/enum plane/enum i9xx_plane_id/

2017-11-21 Thread Ville Syrjälä
On Mon, Nov 20, 2017 at 09:50:28AM -0800, James Ausmus wrote: > On Fri, Nov 17, 2017 at 09:19:10PM +0200, Ville Syrjala wrote: > > From: Ville Syrjälä > > > > Rename enum plane to enum i9xx_plane_id to make it clear that it only > > applies to pre-SKL platforms. >

Re: [Intel-gfx] [PATCH v6 03/10] drm/i915: s/enum plane/enum i9xx_plane_id/

2017-11-20 Thread James Ausmus
On Fri, Nov 17, 2017 at 09:19:10PM +0200, Ville Syrjala wrote: > From: Ville Syrjälä > > Rename enum plane to enum i9xx_plane_id to make it clear that it only > applies to pre-SKL platforms. > > enum i9xx_plane_id is a global identifier, whereas enum plane_id is >

Re: [Intel-gfx] [PATCH v6 03/10] drm/i915: s/enum plane/enum i9xx_plane_id/

2017-11-17 Thread Rodrigo Vivi
On Fri, Nov 17, 2017 at 08:32:19PM +, Ville Syrjälä wrote: > On Fri, Nov 17, 2017 at 12:12:15PM -0800, Rodrigo Vivi wrote: > > On Fri, Nov 17, 2017 at 07:19:10PM +, Ville Syrjala wrote: > > > From: Ville Syrjälä > > > > > > Rename enum plane to enum

Re: [Intel-gfx] [PATCH v6 03/10] drm/i915: s/enum plane/enum i9xx_plane_id/

2017-11-17 Thread Ville Syrjälä
On Fri, Nov 17, 2017 at 12:12:15PM -0800, Rodrigo Vivi wrote: > On Fri, Nov 17, 2017 at 07:19:10PM +, Ville Syrjala wrote: > > From: Ville Syrjälä > > > > Rename enum plane to enum i9xx_plane_id to make it clear that it only > > applies to pre-SKL platforms. >

Re: [Intel-gfx] [PATCH v6 03/10] drm/i915: s/enum plane/enum i9xx_plane_id/

2017-11-17 Thread Rodrigo Vivi
On Fri, Nov 17, 2017 at 07:19:10PM +, Ville Syrjala wrote: > From: Ville Syrjälä > > Rename enum plane to enum i9xx_plane_id to make it clear that it only > applies to pre-SKL platforms. Oh! I should had read this before commenting on the cover letter...

[Intel-gfx] [PATCH v6 03/10] drm/i915: s/enum plane/enum i9xx_plane_id/

2017-11-17 Thread Ville Syrjala
From: Ville Syrjälä Rename enum plane to enum i9xx_plane_id to make it clear that it only applies to pre-SKL platforms. enum i9xx_plane_id is a global identifier, whereas enum plane_id is per-pipe. We need the old global identifier to index the primary plane (and