Re: [Intel-gfx] [PATCH v6 05/20] drm/i915/tdr: Add support for per engine reset recovery

2017-04-25 Thread Chris Wilson
On Mon, Apr 24, 2017 at 02:22:21PM -0700, Michel Thierry wrote: > > > On 20/04/17 17:17, Michel Thierry wrote: > >>Hmm. Interesting. This relies on i915_gem_retire_requests() (i.e. > >>struct_mutex) to skip replaying innocent requests, but here we should be > >>asserting that we do have the hung

Re: [Intel-gfx] [PATCH v6 05/20] drm/i915/tdr: Add support for per engine reset recovery

2017-04-24 Thread Michel Thierry
On 20/04/17 17:17, Michel Thierry wrote: Hmm. Interesting. This relies on i915_gem_retire_requests() (i.e. struct_mutex) to skip replaying innocent requests, but here we should be asserting that we do have the hung request. i.e. request = i915_gem_find_active_request(engine); if (!request)

Re: [Intel-gfx] [PATCH v6 05/20] drm/i915/tdr: Add support for per engine reset recovery

2017-04-20 Thread Michel Thierry
On 19/04/17 03:49, Chris Wilson wrote: On Tue, Apr 18, 2017 at 01:23:20PM -0700, Michel Thierry wrote: From: Arun Siluvery This change implements support for per-engine reset as an initial, less intrusive hang recovery option to be attempted before falling back

Re: [Intel-gfx] [PATCH v6 05/20] drm/i915/tdr: Add support for per engine reset recovery

2017-04-19 Thread Chris Wilson
On Wed, Apr 19, 2017 at 11:49:26AM +0100, Chris Wilson wrote: > On Tue, Apr 18, 2017 at 01:23:20PM -0700, Michel Thierry wrote: > > + ret = i915_gem_reset_prepare_engine(engine); > > + if (ret) { > > + DRM_ERROR("Previous reset failed - promote to full reset\n"); > > + goto

Re: [Intel-gfx] [PATCH v6 05/20] drm/i915/tdr: Add support for per engine reset recovery

2017-04-19 Thread Chris Wilson
On Tue, Apr 18, 2017 at 01:23:20PM -0700, Michel Thierry wrote: > From: Arun Siluvery > > This change implements support for per-engine reset as an initial, less > intrusive hang recovery option to be attempted before falling back to the > legacy full GPU reset

[Intel-gfx] [PATCH v6 05/20] drm/i915/tdr: Add support for per engine reset recovery

2017-04-18 Thread Michel Thierry
From: Arun Siluvery This change implements support for per-engine reset as an initial, less intrusive hang recovery option to be attempted before falling back to the legacy full GPU reset recovery mode if necessary. This is only supported from Gen8 onwards.