Re: [Intel-gfx] [PATCH v6 1/3] drm/i915: enum transcoder and pipe are moved into i915_drm.h

2019-08-20 Thread Ramalingam C
On 2019-08-20 at 15:30:53 +0300, Jani Nikula wrote: > On Tue, 20 Aug 2019, Ramalingam C wrote: > > On 2019-08-20 at 14:14:03 +0530, Winkler, Tomas wrote: > >> > >> > >> > > >> > For the reusability of the enum transcoder and enum pipe in other driver > >> > modules (like mei_hdcp), enum port

Re: [Intel-gfx] [PATCH v6 1/3] drm/i915: enum transcoder and pipe are moved into i915_drm.h

2019-08-20 Thread Jani Nikula
On Tue, 20 Aug 2019, Ramalingam C wrote: > On 2019-08-20 at 14:14:03 +0530, Winkler, Tomas wrote: >> >> >> > >> > For the reusability of the enum transcoder and enum pipe in other driver >> > modules (like mei_hdcp), enum port definition is moved from I915 local >> > header >> >

Re: [Intel-gfx] [PATCH v6 1/3] drm/i915: enum transcoder and pipe are moved into i915_drm.h

2019-08-20 Thread Ramalingam C
On 2019-08-20 at 14:14:03 +0530, Winkler, Tomas wrote: > > > > > > For the reusability of the enum transcoder and enum pipe in other driver > > modules (like mei_hdcp), enum port definition is moved from I915 local > > header > > intel_display.h to drm/i915_drm.h > > Don't you need to name

Re: [Intel-gfx] [PATCH v6 1/3] drm/i915: enum transcoder and pipe are moved into i915_drm.h

2019-08-20 Thread Winkler, Tomas
> > For the reusability of the enum transcoder and enum pipe in other driver > modules (like mei_hdcp), enum port definition is moved from I915 local header > intel_display.h to drm/i915_drm.h Don't you need to name space those definitions in the global space, I guess there are a lot of

[Intel-gfx] [PATCH v6 1/3] drm/i915: enum transcoder and pipe are moved into i915_drm.h

2019-08-20 Thread Ramalingam C
For the reusability of the enum transcoder and enum pipe in other driver modules (like mei_hdcp), enum port definition is moved from I915 local header intel_display.h to drm/i915_drm.h Signed-off-by: Ramalingam C --- drivers/gpu/drm/i915/display/intel_display.h | 44 ---

[Intel-gfx] [PATCH v6 1/3] drm/i915: enum transcoder and pipe are moved into i915_drm.h

2019-08-19 Thread Ramalingam C
For the reusability of the enum transcoder and enum pipe in other driver modules (like mei_hdcp), enum port definition is moved from I915 local header intel_display.h to drm/i915_drm.h Signed-off-by: Ramalingam C --- drivers/gpu/drm/i915/display/intel_display.h | 44 ---