On 01/31/2018 11:37 PM, Chris Wilson wrote:
Quoting Jackie Li (2018-01-19 01:29:27)
intel_guc_reg.h should only include definition for GuC registers
and related register bits. GuC WOPCM related values should not
be defined in intel_guc_reg.h
GuC registers does not include GuC WOPCM? The code
Quoting Jackie Li (2018-01-19 01:29:27)
> intel_guc_reg.h should only include definition for GuC registers
> and related register bits. GuC WOPCM related values should not
> be defined in intel_guc_reg.h
GuC registers does not include GuC WOPCM? The code does seem to suggest
they are related ;)
Patch looks good to me. Minor updates suggested below with r-b.
On 1/19/2018 6:59 AM, Jackie Li wrote:
intel_guc_reg.h should only include definition for GuC registers
and related register bits. GuC WOPCM related values should not
be defined in intel_guc_reg.h
This patch creates a better file
intel_guc_reg.h should only include definition for GuC registers
and related register bits. GuC WOPCM related values should not
be defined in intel_guc_reg.h
This patch creates a better file structure by moving GuC WOPCM
related definitions int to a new header intel_guc_wopcm.h
and moving GuC
