Re: [Intel-gfx] [PATCH v7 6/7] drm/i915/tgl: switch between dc3co and dc5 based on display idleness

2019-09-11 Thread Anshuman Gupta
On 2019-09-11 at 11:50:26 +0300, Imre Deak wrote: > On Tue, Sep 10, 2019 at 03:26:20PM +0530, Anshuman Gupta wrote: > > On 2019-09-08 at 20:55:17 +0300, Imre Deak wrote: > > Hi Imre , > > Thanks for review, could you please provide your response on below > > comments. > > > On Sat, Sep 07, 2019 at

Re: [Intel-gfx] [PATCH v7 6/7] drm/i915/tgl: switch between dc3co and dc5 based on display idleness

2019-09-11 Thread Imre Deak
On Tue, Sep 10, 2019 at 03:26:20PM +0530, Anshuman Gupta wrote: > On 2019-09-08 at 20:55:17 +0300, Imre Deak wrote: > Hi Imre , > Thanks for review, could you please provide your response on below > comments. > > On Sat, Sep 07, 2019 at 10:44:42PM +0530, Anshuman Gupta wrote: > > > DC3CO is useful

Re: [Intel-gfx] [PATCH v7 6/7] drm/i915/tgl: switch between dc3co and dc5 based on display idleness

2019-09-10 Thread Anshuman Gupta
On 2019-09-08 at 20:55:17 +0300, Imre Deak wrote: Hi Imre , Thanks for review, could you please provide your response on below comments. > On Sat, Sep 07, 2019 at 10:44:42PM +0530, Anshuman Gupta wrote: > > DC3CO is useful power state, when DMC detects PSR2 idle frame > > while an active video

Re: [Intel-gfx] [PATCH v7 6/7] drm/i915/tgl: switch between dc3co and dc5 based on display idleness

2019-09-08 Thread Imre Deak
On Sat, Sep 07, 2019 at 10:44:42PM +0530, Anshuman Gupta wrote: > DC3CO is useful power state, when DMC detects PSR2 idle frame > while an active video playback, playing 30fps video on 60hz panel > is the classic example of this use case. > DC5 and DC6 saves more power, but can't be entered during

[Intel-gfx] [PATCH v7 6/7] drm/i915/tgl: switch between dc3co and dc5 based on display idleness

2019-09-07 Thread Anshuman Gupta
DC3CO is useful power state, when DMC detects PSR2 idle frame while an active video playback, playing 30fps video on 60hz panel is the classic example of this use case. DC5 and DC6 saves more power, but can't be entered during video playback because there are not enough idle frames in a row to