Re: [Intel-gfx] [RESEND] drm/i915: stop conflating HAS_DISPLAY() and disabled display

2019-09-16 Thread Jani Nikula
On Mon, 16 Sep 2019, Ville Syrjälä wrote: > On Mon, Sep 16, 2019 at 05:05:10PM +0300, Jani Nikula wrote: >> On Mon, 16 Sep 2019, Chris Wilson wrote: >> > Quoting Jani Nikula (2019-09-16 10:29:01) >> >> Stop setting ->pipe_mask to zero when display is disabled, allowing us >> >> to have different

Re: [Intel-gfx] [RESEND] drm/i915: stop conflating HAS_DISPLAY() and disabled display

2019-09-16 Thread Chris Wilson
Quoting Ville Syrjälä (2019-09-16 15:27:40) > On Mon, Sep 16, 2019 at 05:05:10PM +0300, Jani Nikula wrote: > > The main goal here (in this specific patch) is to decouple disabled but > > existing display from non-existing display. That lets us develop the two > > cases independently, and I

Re: [Intel-gfx] [RESEND] drm/i915: stop conflating HAS_DISPLAY() and disabled display

2019-09-16 Thread Ville Syrjälä
On Mon, Sep 16, 2019 at 05:05:10PM +0300, Jani Nikula wrote: > On Mon, 16 Sep 2019, Chris Wilson wrote: > > Quoting Jani Nikula (2019-09-16 10:29:01) > >> Stop setting ->pipe_mask to zero when display is disabled, allowing us > >> to have different code paths for not actually having display

Re: [Intel-gfx] [RESEND] drm/i915: stop conflating HAS_DISPLAY() and disabled display

2019-09-16 Thread Chris Wilson
Quoting Jani Nikula (2019-09-16 10:29:01) > Stop setting ->pipe_mask to zero when display is disabled, allowing us > to have different code paths for not actually having display hardware, > and having display hardware disabled. This lets us develop those two > avenues independently. > > There are

Re: [Intel-gfx] [RESEND] drm/i915: stop conflating HAS_DISPLAY() and disabled display

2019-09-16 Thread Jani Nikula
On Mon, 16 Sep 2019, Chris Wilson wrote: > Quoting Jani Nikula (2019-09-16 10:29:01) >> Stop setting ->pipe_mask to zero when display is disabled, allowing us >> to have different code paths for not actually having display hardware, >> and having display hardware disabled. This lets us develop

Re: [Intel-gfx] [RESEND] drm/i915: stop conflating HAS_DISPLAY() and disabled display

2019-09-16 Thread Chris Wilson
Quoting Jani Nikula (2019-09-16 10:29:01) > Stop setting ->pipe_mask to zero when display is disabled, allowing us > to have different code paths for not actually having display hardware, > and having display hardware disabled. This lets us develop those two > avenues independently. > > There are

[Intel-gfx] [RESEND] drm/i915: stop conflating HAS_DISPLAY() and disabled display

2019-09-16 Thread Jani Nikula
Stop setting ->pipe_mask to zero when display is disabled, allowing us to have different code paths for not actually having display hardware, and having display hardware disabled. This lets us develop those two avenues independently. There are no functional changes for when there is no display.