Re: [Intel-gfx] [RFC] drm/i915: Add a new modparam for customized ring multiplier

2018-01-08 Thread Sagar Arun Kamble
On 1/6/2018 5:53 AM, Yaodong Li wrote: On 01/05/2018 02:15 AM, Sagar Arun Kamble wrote: On 1/5/2018 3:22 AM, Yaodong Li wrote: On 01/03/2018 10:10 PM, Sagar Arun Kamble wrote: Since ring frequency programming needs consideration of both IA and GT frequency requests I think keeping the

Re: [Intel-gfx] [RFC] drm/i915: Add a new modparam for customized ring multiplier

2018-01-05 Thread Yaodong Li
On 01/05/2018 02:15 AM, Sagar Arun Kamble wrote: On 1/5/2018 3:22 AM, Yaodong Li wrote: On 01/03/2018 10:10 PM, Sagar Arun Kamble wrote: Since ring frequency programming needs consideration of both IA and GT frequency requests I think keeping the logic to program the ring frequency table in

Re: [Intel-gfx] [RFC] drm/i915: Add a new modparam for customized ring multiplier

2018-01-05 Thread Sagar Arun Kamble
On 1/5/2018 3:22 AM, Yaodong Li wrote: On 01/03/2018 10:10 PM, Sagar Arun Kamble wrote: Since ring frequency programming needs consideration of both IA and GT frequency requests I think keeping the logic to program the ring frequency table in driver that monitors both IA/GT busyness and

Re: [Intel-gfx] [RFC] drm/i915: Add a new modparam for customized ring multiplier

2018-01-04 Thread Yaodong Li
On 01/03/2018 10:10 PM, Sagar Arun Kamble wrote: Since ring frequency programming needs consideration of both IA and GT frequency requests I think keeping the logic to program the ring frequency table in driver that monitors both IA/GT busyness and power budgets like intel_ips will be more

Re: [Intel-gfx] [RFC] drm/i915: Add a new modparam for customized ring multiplier

2018-01-03 Thread Sagar Arun Kamble
Since ring frequency programming needs consideration of both IA and GT frequency requests I think keeping the logic to program the ring frequency table in driver that monitors both IA/GT busyness and power budgets like intel_ips will be more appropriate. intel_ips is relying on global load

Re: [Intel-gfx] [RFC] drm/i915: Add a new modparam for customized ring multiplier

2018-01-03 Thread Yaodong Li
You are thinking of plugging into intel_pstate to make it smarter for ia freq transitions? Yep. This seems a correct step to give some automatic support instead of parameter/hardcoded multiplier. Does this mean we should use cpufreq/intel_pstate based approach instead of the current

Re: [Intel-gfx] [RFC] drm/i915: Add a new modparam for customized ring multiplier

2017-12-27 Thread Rogozhkin, Dmitry V
l-gfx@lists.freedesktop.org Cc: Widawsky, Benjamin <benjamin.widaw...@intel.com> Subject: Re: [Intel-gfx] [RFC] drm/i915: Add a new modparam for customized ring multiplier >> To clarify, the HW will flip between the two GT/IA requests rather than >> stick to the highest? Yes, it will

Re: [Intel-gfx] [RFC] drm/i915: Add a new modparam for customized ring multiplier

2017-12-26 Thread Rogozhkin, Dmitry V
>> To clarify, the HW will flip between the two GT/IA requests rather than >> stick to the highest? Yes, it will flip on Gen9. On Gen8 there was some mechanism (HW) which flattened that. But it was removed/substituted in Gen9. In Gen10 it was tuned to close the mentioned issue. >> Do you

Re: [Intel-gfx] [RFC] drm/i915: Add a new modparam for customized ring multiplier

2017-12-26 Thread Chris Wilson
Quoting Rogozhkin, Dmitry V (2017-12-26 16:39:23) > Clarification on the issue. Consider that you have a massive load on GT and > just tiny one on IA. If GT will program the RING frequency to be lower than > IA frequency, then you will fall into the situation when RING frequency > constantly

Re: [Intel-gfx] [RFC] drm/i915: Add a new modparam for customized ring multiplier

2017-12-26 Thread Rogozhkin, Dmitry V
Clarification on the issue. Consider that you have a massive load on GT and just tiny one on IA. If GT will program the RING frequency to be lower than IA frequency, then you will fall into the situation when RING frequency constantly transits from GT to IA level and back. Each transition of a

Re: [Intel-gfx] [RFC] drm/i915: Add a new modparam for customized ring multiplier

2017-12-26 Thread Chris Wilson
Quoting Chris Wilson (2017-12-18 21:47:25) > Quoting Jackie Li (2017-12-18 21:22:08) > > From: Zhipeng Gong > > > > SKL platforms requires a higher ring multiplier when there's massive > > GPU load. Current driver doesn't provide a way to override the ring > > multiplier.

Re: [Intel-gfx] [RFC] drm/i915: Add a new modparam for customized ring multiplier

2017-12-18 Thread Yaodong Li
On 12/18/2017 01:47 PM, Chris Wilson wrote: Quoting Jackie Li (2017-12-18 21:22:08) From: Zhipeng Gong SKL platforms requires a higher ring multiplier when there's massive GPU load. Current driver doesn't provide a way to override the ring multiplier. This patch adds

Re: [Intel-gfx] [RFC] drm/i915: Add a new modparam for customized ring multiplier

2017-12-18 Thread Chris Wilson
Quoting Jackie Li (2017-12-18 21:22:08) > From: Zhipeng Gong > > SKL platforms requires a higher ring multiplier when there's massive > GPU load. Current driver doesn't provide a way to override the ring > multiplier. > > This patch adds a new module parameter to allow

[Intel-gfx] [RFC] drm/i915: Add a new modparam for customized ring multiplier

2017-12-18 Thread Jackie Li
From: Zhipeng Gong SKL platforms requires a higher ring multiplier when there's massive GPU load. Current driver doesn't provide a way to override the ring multiplier. This patch adds a new module parameter to allow the overriding of ring multiplier for Gen9 platforms.