Re: [Intel-gfx] [RFC 01/44] drm/i915: Corrected 'file_priv' to 'file' in 'i915_driver_preclose()'

2014-07-07 Thread Daniel Vetter
On Mon, Jun 30, 2014 at 02:03:18PM -0700, Jesse Barnes wrote: > On Thu, 26 Jun 2014 18:23:52 +0100 > john.c.harri...@intel.com wrote: > > > From: John Harrison > > > > The 'i915_driver_preclose()' function has a parameter called 'file_priv'. > > However, this is misleading as the structure it po

Re: [Intel-gfx] [RFC 01/44] drm/i915: Corrected 'file_priv' to 'file' in 'i915_driver_preclose()'

2014-06-30 Thread Jesse Barnes
On Thu, 26 Jun 2014 18:23:52 +0100 john.c.harri...@intel.com wrote: > From: John Harrison > > The 'i915_driver_preclose()' function has a parameter called 'file_priv'. > However, this is misleading as the structure it points to is a 'drm_file' not > a > 'drm_i915_file_private'. It should be nam

[Intel-gfx] [RFC 01/44] drm/i915: Corrected 'file_priv' to 'file' in 'i915_driver_preclose()'

2014-06-26 Thread John . C . Harrison
From: John Harrison The 'i915_driver_preclose()' function has a parameter called 'file_priv'. However, this is misleading as the structure it points to is a 'drm_file' not a 'drm_i915_file_private'. It should be named just 'file' to avoid confusion. --- drivers/gpu/drm/i915/i915_dma.c |6 +++