Re: [Intel-gfx] [RFC PATCH 1/3] drm/915: Add private api for power well usage

2013-05-10 Thread Wang, Xingchao
Hi Takashi, -Original Message- From: Takashi Iwai [mailto:ti...@suse.de] Sent: Friday, May 10, 2013 1:18 AM To: Daniel Vetter Cc: Wang, Xingchao; david.hennings...@canonical.com; Girdwood, Liam R; Barnes, Jesse; Li, Jocelyn; Lin, Mengdong; Zanoni, Paulo R; Wang Xingchao; intel-gfx;

Re: [Intel-gfx] [RFC PATCH 1/3] drm/915: Add private api for power well usage

2013-05-10 Thread Wang, Xingchao
Hi Jesse, -Original Message- From: Barnes, Jesse Sent: Friday, May 10, 2013 2:30 AM To: Takashi Iwai Cc: Daniel Vetter; Wang, Xingchao; david.hennings...@canonical.com; Girdwood, Liam R; Li, Jocelyn; Lin, Mengdong; Zanoni, Paulo R; Wang Xingchao; intel-gfx;

Re: [Intel-gfx] [RFC PATCH 1/3] drm/915: Add private api for power well usage

2013-05-09 Thread Daniel Vetter
Hi all, Three things: 1. Any reason public mailing lists (intel-gfx, alsa-devel) aren't cc'ed? Afaics no secret stuff is being discussed here ... Please resend the patches with mailings lists cc'ed. 2. On a quick read of the hda driver stuff I don't think the power well enable/disable places are

Re: [Intel-gfx] [RFC PATCH 1/3] drm/915: Add private api for power well usage

2013-05-09 Thread Wang, Xingchao
Hi Daniel, -Original Message- From: daniel.vet...@ffwll.ch [mailto:daniel.vet...@ffwll.ch] On Behalf Of Daniel Vetter Sent: Thursday, May 09, 2013 5:23 PM To: Wang, Xingchao Cc: david.hennings...@canonical.com; Girdwood, Liam R; ti...@suse.de; Barnes, Jesse; Li, Jocelyn; Lin,

Re: [Intel-gfx] [RFC PATCH 1/3] drm/915: Add private api for power well usage

2013-05-09 Thread Takashi Iwai
At Thu, 9 May 2013 11:23:21 +0200, Daniel Vetter wrote: 2. On a quick read of the hda driver stuff I don't think the power well enable/disable places are at the right spot: We force the power well on whenever the hda codec is used, but we must only do that when we want to output audio to

Re: [Intel-gfx] [RFC PATCH 1/3] drm/915: Add private api for power well usage

2013-05-09 Thread Jesse Barnes
On Thu, 9 May 2013 19:17:36 +0200 Takashi Iwai ti...@suse.de wrote: At Thu, 9 May 2013 11:23:21 +0200, Daniel Vetter wrote: 2. On a quick read of the hda driver stuff I don't think the power well enable/disable places are at the right spot: We force the power well on whenever the hda

Re: [Intel-gfx] [RFC PATCH 1/3] drm/915: Add private api for power well usage

2013-05-09 Thread Jesse Barnes
On Thu, 9 May 2013 11:30:01 -0700 Jesse Barnes jesse.bar...@intel.com wrote: The question is in which level we need power_well_*() controls. If the initialization of HD-audio controller (e.g. PCI registers) requires the power well on, hda_intel.c requires the calls, as this patch does.