On Fri, Jan 27, 2017 at 08:55:19AM -0600, Pierre-Louis Bossart wrote:
>
>
> > +#define AUD_PORT_EN_B_DBG 0x62F20
> > +#define AUD_PORT_EN_C_DBG 0x62F28
> > +#define AUD_PORT_EN_D_DBG 0x62F2C
> >>> These match the spec. But to match the standard i
On Fri, Jan 27, 2017 at 08:47:50AM -0600, Pierre-Louis Bossart wrote:
> Thanks Jani and Ville for the comments. Couple of precisions needed below:
> >>
> >>> #define GEN6_BSD_RNCID _MMIO(0x12198)
> >>>
> >>> #define GEN7_FF_THREAD_MODE _MMIO(0x20a0)
> >>> diff --
+#define AUD_PORT_EN_B_DBG 0x62F20
+#define AUD_PORT_EN_C_DBG 0x62F28
+#define AUD_PORT_EN_D_DBG 0x62F2C
These match the spec. But to match the standard i915 convention they
should be called _AUD_PORT_EN_B_DBG etc. Same forthe chicken bit
register.
Actua
Thanks Jani and Ville for the comments. Couple of precisions needed below:
#define GEN6_BSD_RNCID_MMIO(0x12198)
#define GEN7_FF_THREAD_MODE _MMIO(0x20a0)
diff --git a/drivers/gpu/drm/i915/intel_lpe_audio.c
b/drivers/gpu/drm/i915/intel_lpe_audio.c
index 245523e.
On Fri, 27 Jan 2017 15:35:47 +0100,
Ville Syrjälä wrote:
>
> On Fri, Jan 27, 2017 at 03:17:34PM +0200, Ville Syrjälä wrote:
> > On Fri, Jan 27, 2017 at 12:08:58PM +0200, Jani Nikula wrote:
> > > On Thu, 26 Jan 2017, Pierre-Louis Bossart
> > > wrote:
> > > > Enable chicken bit on LPE mode setup a
On Fri, Jan 27, 2017 at 03:17:34PM +0200, Ville Syrjälä wrote:
> On Fri, Jan 27, 2017 at 12:08:58PM +0200, Jani Nikula wrote:
> > On Thu, 26 Jan 2017, Pierre-Louis Bossart
> > wrote:
> > > Enable chicken bit on LPE mode setup and unmute amp on
> > > notification
> > >
> > > FIXME: should these tw
On Fri, Jan 27, 2017 at 03:51:34PM +0200, Jani Nikula wrote:
> On Fri, 27 Jan 2017, Ville Syrjälä wrote:
> > On Fri, Jan 27, 2017 at 12:08:58PM +0200, Jani Nikula wrote:
> >> On Thu, 26 Jan 2017, Pierre-Louis Bossart
> >> wrote:
> >> > Enable chicken bit on LPE mode setup and unmute amp on
> >>
On Fri, 27 Jan 2017, Ville Syrjälä wrote:
> On Fri, Jan 27, 2017 at 12:08:58PM +0200, Jani Nikula wrote:
>> On Thu, 26 Jan 2017, Pierre-Louis Bossart
>> wrote:
>> > Enable chicken bit on LPE mode setup and unmute amp on
>> > notification
>> >
>> > FIXME: should these two phases done somewhere el
On Fri, Jan 27, 2017 at 12:08:58PM +0200, Jani Nikula wrote:
> On Thu, 26 Jan 2017, Pierre-Louis Bossart
> wrote:
> > Enable chicken bit on LPE mode setup and unmute amp on
> > notification
> >
> > FIXME: should these two phases done somewhere else?
> >
> > Signed-off-by: Pierre-Louis Bossart
>
On Thu, 26 Jan 2017, Pierre-Louis Bossart
wrote:
> Enable chicken bit on LPE mode setup and unmute amp on
> notification
>
> FIXME: should these two phases done somewhere else?
>
> Signed-off-by: Pierre-Louis Bossart
> ---
> drivers/gpu/drm/i915/i915_reg.h| 12
> drivers/gp
Enable chicken bit on LPE mode setup and unmute amp on
notification
FIXME: should these two phases done somewhere else?
Signed-off-by: Pierre-Louis Bossart
---
drivers/gpu/drm/i915/i915_reg.h| 12
drivers/gpu/drm/i915/intel_lpe_audio.c | 27 +++
2 fi
11 matches
Mail list logo